Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drainpipe does not support Github enterprise #739

Open
tess-ten7 opened this issue Nov 22, 2024 · 1 comment
Open

Drainpipe does not support Github enterprise #739

tess-ten7 opened this issue Nov 22, 2024 · 1 comment

Comments

@tess-ten7
Copy link

In PantheonReviewApps.yml, the ./.github/actions/drainpipe/pantheon/review action calls out to https://api.github.com. This fails immediately on Github Enterprise instances which have a different URL. There is no way to customize the URL through a parameter either.

@deviantintegral
Copy link
Member

This is self-hosted enterprise instances, or enterprise in the cloud? If it's the later, I bet there's some way we can automatically switch that. However, we have one client on enterprise cloud and I think we're calling api.github.com and it's wroking fine, so it's probably not needed.

For self hosted, we have no clients currently using it. I think we'd be glad to review a PR on this, but since we can't test it ourselves we'd need you or someone else with access to pick this one up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants