-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stream large HTTP bodies #256
Labels
qol
Improvements that make usage smoother, without introducing new functionality
Comments
LucasPickering
added
the
qol
Improvements that make usage smoother, without introducing new functionality
label
Jun 9, 2024
3 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
It should be possible to stream large HTTP bodies (e.g. large file uploads), such that the entire body is never loaded into memory.
Describe the solution you'd like
A clear and concise description of what you want to happen
Templates should provide a
Stream
interface that allows you to stream bytes from them rather than loading and stitching everything together. For raw sections of the template we could just stream what's already in memory. For chains we could stream from whatever the byte source is (file, command, etc.).We need a way to tell Slumber when to do this. For
multipart
requests it's easy, just always do it because reqwest insists on it. It should be possible to opt-in for any recipe though. The easy solution is a booleanstream
field on the recipe, but we should consider alternatives.We should also find a decent way to store the streamed body in history. Since we can't store the whole bytes, maybe just some sort of descriptor of where the data was streamed from.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered
Additional context
Add any other context or screenshots about the feature request here
The text was updated successfully, but these errors were encountered: