Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a single comment per PR #21

Closed
WyriHaximus opened this issue Dec 1, 2024 · 7 comments · Fixed by #22
Closed

Using a single comment per PR #21

WyriHaximus opened this issue Dec 1, 2024 · 7 comments · Fixed by #22
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@WyriHaximus
Copy link

Using this action for my GitHub Workflows and Helm Chart to make sure the generated README's are regenerated when PR's are created. Because it doesn't do this it gets rather spammy when iterating over a PR: WyriHaximusNet/helm-charts#125

Would you be interested in a PR adding this functionality?

@LouisBrunner
Copy link
Owner

Hi @WyriHaximus,

We can definitely look into that! (unless you are interested in contributing? 😄)

@LouisBrunner LouisBrunner added enhancement New feature or request good first issue Good for newcomers labels Dec 1, 2024
@WyriHaximus
Copy link
Author

We can definitely look into that! (unless you are interested in contributing? 😄)

Good with both, would have to research how to implement this. Did this in two of my own actions, but neither uses JS

@LouisBrunner
Copy link
Owner

If you already have an example I can look at that would be great. I can try to put something together tomorrow.

@WyriHaximus
Copy link
Author

@LouisBrunner
Copy link
Owner

LouisBrunner commented Dec 5, 2024

Thanks for the references! I will release the changes (i.e. the new attribute sticky_comment: true) as v2.1.0 soon.

Edit: done!

@WyriHaximus
Copy link
Author

Awesome, and it uses the title to distinguish between multiple comments. Thanks ❤️ !

WyriHaximus added a commit to WyriHaximusNet/helm-charts that referenced this issue Dec 5, 2024
WyriHaximus added a commit to WyriHaximus/github-workflows that referenced this issue Dec 5, 2024
WyriHaximus added a commit to WyriHaximus/github-workflows that referenced this issue Dec 5, 2024
WyriHaximus added a commit to WyriHaximusNet/helm-charts that referenced this issue Dec 5, 2024
WyriHaximus added a commit to WyriHaximus/github-workflows that referenced this issue Dec 5, 2024
WyriHaximus added a commit to WyriHaximus/github-workflows that referenced this issue Dec 5, 2024
WyriHaximus added a commit to WyriHaximusNet/helm-charts that referenced this issue Dec 5, 2024
WyriHaximus added a commit to WyriHaximus/github-workflows that referenced this issue Dec 5, 2024
WyriHaximus added a commit to WyriHaximusNet/helm-charts that referenced this issue Dec 5, 2024
@WyriHaximus
Copy link
Author

Thanks again, just set it up on WyriHaximus/github-workflows#53 and WyriHaximusNet/helm-charts#127 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants