-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using a single comment per PR #21
Comments
Hi @WyriHaximus, We can definitely look into that! (unless you are interested in contributing? 😄) |
Good with both, would have to research how to implement this. Did this in two of my own actions, but neither uses JS |
If you already have an example I can look at that would be great. I can try to put something together tomorrow. |
Pure PHP implementation: https://github.com/WyriHaximus/github-action-composer.lock-diff/blob/main/generate-comments/comment.php I've been meaning to replace with https://github.com/marocchino/sticky-pull-request-comment, which I'm using in my workflows. This is probably the code you're looking for: https://github.com/marocchino/sticky-pull-request-comment/blob/main/src/comment.ts#L26-L158 |
Thanks for the references! I will release the changes (i.e. the new attribute Edit: done! |
Awesome, and it uses the title to distinguish between multiple comments. Thanks ❤️ ! |
After filing LouisBrunner/diff-action#21 this was addressed in LouisBrunner/diff-action#22 and released in https://github.com/LouisBrunner/diff-action/releases/tag/v2.1.0
After filing LouisBrunner/diff-action#21 this was addressed in LouisBrunner/diff-action#22 and released in https://github.com/LouisBrunner/diff-action/releases/tag/v2.1.0
After filing LouisBrunner/diff-action#21 this was addressed in LouisBrunner/diff-action#22 and released in https://github.com/LouisBrunner/diff-action/releases/tag/v2.1.0
After filing LouisBrunner/diff-action#21 this was addressed in LouisBrunner/diff-action#22 and released in https://github.com/LouisBrunner/diff-action/releases/tag/v2.1.0
After filing LouisBrunner/diff-action#21 this was addressed in LouisBrunner/diff-action#22 and released in https://github.com/LouisBrunner/diff-action/releases/tag/v2.1.0
After filing LouisBrunner/diff-action#21 this was addressed in LouisBrunner/diff-action#22 and released in https://github.com/LouisBrunner/diff-action/releases/tag/v2.1.0
After filing LouisBrunner/diff-action#21 this was addressed in LouisBrunner/diff-action#22 and released in https://github.com/LouisBrunner/diff-action/releases/tag/v2.1.0
After filing LouisBrunner/diff-action#21 this was addressed in LouisBrunner/diff-action#22 and released in https://github.com/LouisBrunner/diff-action/releases/tag/v2.1.0
After filing LouisBrunner/diff-action#21 this was addressed in LouisBrunner/diff-action#22 and released in https://github.com/LouisBrunner/diff-action/releases/tag/v2.1.0
Thanks again, just set it up on WyriHaximus/github-workflows#53 and WyriHaximusNet/helm-charts#127 👍 |
Using this action for my GitHub Workflows and Helm Chart to make sure the generated README's are regenerated when PR's are created. Because it doesn't do this it gets rather spammy when iterating over a PR: WyriHaximusNet/helm-charts#125
Would you be interested in a PR adding this functionality?
The text was updated successfully, but these errors were encountered: