tr1/carrier: add support for TR2-style item drops #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahm86
requested review from
rr-,
walkawayy and
aredfan
and removed request for
a team
This allows item drops to be defined in the level data in the same fashion as TR2, so any pickup item that is in the same position as an enemy will be carried by that enemy. The gameflow approach is retained for OG levels, and the provided gameflow setting will default to this. Resolves LostArtefacts#1713.
lahm86
force-pushed
the
issue-1713-improved-item-drops
branch
from
c6867c6 to
3846e03
Compare
rr-
approved these changes
Oct 15, 2024
aredfan
approved these changes
Oct 16, 2024
This moves the enemy status check when testing item drops into a separate function for clarity, and checks additionally for the Qualopec mummy, whose hitpoints will still be greater than 0 when Lara touches it, and this still qualifies as a kill.
Thank you, good catch. That should be fixed now. |
aredfan
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1713.
Checklist
Description
This allows item drops to be defined in the level data in the same fashion as TR2, so any pickup item that is in the same position as an enemy will be carried by that enemy. The gameflow approach is retained for OG levels, and the provided gameflow setting will default to this.
For OG, Pierre in Tihocan and the enemies in Natla's Mines should continue to drop as normal. If the gameflow setting is enabled in OG, then they will not drop anything (and indeed the ape in room 82 of Tihocan will drop shotgun shells).
Attached is a custom level with every enemy type and some drops allocated to each. Similarly, if the gameflow setting is disabled here, then the items will appear normally (albeit some will float as they're positioned with the enemy).
LEVEL1.zip