Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config_tool: migrate to common config library #1491

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

lahm86
Copy link
Collaborator

@lahm86 lahm86 commented Sep 5, 2024

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

This moves over to the new config library in libtrx, so we now have only need a minimal solution with the specification, language, graphics etc. The docker entrypoint will first build the common library in the subprojects folder, then build the executable, which has a reference to the release path.

There should be no visual or functional difference in the config tool itself when testing.

@lahm86 lahm86 added the Internal The invisible stuff label Sep 5, 2024
@lahm86 lahm86 added this to the 4.4 milestone Sep 5, 2024
@lahm86 lahm86 self-assigned this Sep 5, 2024
@lahm86 lahm86 marked this pull request as ready for review September 5, 2024 15:20
@lahm86 lahm86 requested review from a team as code owners September 5, 2024 15:20
@lahm86 lahm86 requested review from rr- and walkawayy and removed request for a team September 5, 2024 15:20
Copy link
Collaborator

@rr- rr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. I'm stepping out for the day – Can someone confirm if the config tool is properly bundled in this PR builds, has the icon, and doesn't show console windows when launched? (Mostly thinking about integration with GitHub Actions and Docker here)

@aredfan
Copy link
Collaborator

aredfan commented Sep 5, 2024

Code LGTM. I'm stepping out for the day – Can someone confirm if the config tool is properly bundled in this PR builds, has the icon, and doesn't show console windows when launched? (Mostly thinking about integration with GitHub Actions and Docker here)

Yes on all 3 counts. I've checked the config tool bundled with win and win-installer.

@lahm86 lahm86 merged commit 48f40c4 into LostArtefacts:develop Sep 5, 2024
5 checks passed
@lahm86 lahm86 deleted the use-common-config-tool branch September 5, 2024 17:40
@rr- rr- added the TR1 label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal The invisible stuff TR1
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants