From 75f9aad826c23ea927707bc05bdde96b00838284 Mon Sep 17 00:00:00 2001 From: Warith Rahman Date: Wed, 23 Oct 2024 00:38:50 -0500 Subject: [PATCH 01/13] fix(header): bottom-aligned the schedule name + hours/courses in calendar --- src/stories/components/calendar/CalendarHeader.stories.tsx | 2 +- src/views/components/calendar/Calendar.tsx | 2 +- .../calendar/{CalenderHeader.tsx => CalendarHeader.tsx} | 0 src/views/components/common/ScheduleTotalHoursAndCourses.tsx | 4 ++-- 4 files changed, 4 insertions(+), 4 deletions(-) rename src/views/components/calendar/{CalenderHeader.tsx => CalendarHeader.tsx} (100%) diff --git a/src/stories/components/calendar/CalendarHeader.stories.tsx b/src/stories/components/calendar/CalendarHeader.stories.tsx index b9738f22b..b2d2cf26c 100644 --- a/src/stories/components/calendar/CalendarHeader.stories.tsx +++ b/src/stories/components/calendar/CalendarHeader.stories.tsx @@ -1,5 +1,5 @@ import type { Meta, StoryObj } from '@storybook/react'; -import CalendarHeader from '@views/components/calendar/CalenderHeader'; +import CalendarHeader from '@views/components/calendar/CalendarHeader'; const meta = { title: 'Components/Calendar/CalendarHeader', diff --git a/src/views/components/calendar/Calendar.tsx b/src/views/components/calendar/Calendar.tsx index c1ad86dd3..652527880 100644 --- a/src/views/components/calendar/Calendar.tsx +++ b/src/views/components/calendar/Calendar.tsx @@ -2,8 +2,8 @@ import type { CalendarTabMessages } from '@shared/messages/CalendarMessages'; import type { Course } from '@shared/types/Course'; import CalendarBottomBar from '@views/components/calendar/CalendarBottomBar'; import CalendarGrid from '@views/components/calendar/CalendarGrid'; +import CalendarHeader from '@views/components/calendar/CalendarHeader'; import { CalendarSchedules } from '@views/components/calendar/CalendarSchedules'; -import CalendarHeader from '@views/components/calendar/CalenderHeader'; import ImportantLinks from '@views/components/calendar/ImportantLinks'; import Divider from '@views/components/common/Divider'; import CourseCatalogInjectedPopup from '@views/components/injected/CourseCatalogInjectedPopup/CourseCatalogInjectedPopup'; diff --git a/src/views/components/calendar/CalenderHeader.tsx b/src/views/components/calendar/CalendarHeader.tsx similarity index 100% rename from src/views/components/calendar/CalenderHeader.tsx rename to src/views/components/calendar/CalendarHeader.tsx diff --git a/src/views/components/common/ScheduleTotalHoursAndCourses.tsx b/src/views/components/common/ScheduleTotalHoursAndCourses.tsx index 671b1a577..d7e89207e 100644 --- a/src/views/components/common/ScheduleTotalHoursAndCourses.tsx +++ b/src/views/components/common/ScheduleTotalHoursAndCourses.tsx @@ -21,11 +21,11 @@ export default function ScheduleTotalHoursAndCourses({ totalCourses, }: ScheduleTotalHoursAndCoursesProps): JSX.Element { return ( -
+
{`${scheduleName}: `} - + {totalHours} {totalHours === 1 ? 'Hour' : 'Hours'} {totalCourses} {totalCourses === 1 ? 'Course' : 'Courses'} From 0afc6c9fb7691caf456703fc6a08bed162041ff4 Mon Sep 17 00:00:00 2001 From: Warith Rahman Date: Wed, 23 Oct 2024 10:36:40 -0500 Subject: [PATCH 02/13] feat: updated font style in header and dropdown --- .../components/common/ScheduleDropdown.tsx | 4 ++-- .../common/ScheduleTotalHoursAndCourses.tsx | 24 ++++++++++++++----- 2 files changed, 20 insertions(+), 8 deletions(-) diff --git a/src/views/components/common/ScheduleDropdown.tsx b/src/views/components/common/ScheduleDropdown.tsx index c806478c8..b3c29cfae 100644 --- a/src/views/components/common/ScheduleDropdown.tsx +++ b/src/views/components/common/ScheduleDropdown.tsx @@ -27,14 +27,14 @@ export default function ScheduleDropdown(props: ScheduleDropdownProps) { <>
- + {(activeSchedule ? activeSchedule.name : 'Schedule').toUpperCase()}:

{activeSchedule ? activeSchedule.hours : 0} HOURS - + {activeSchedule ? activeSchedule.courses.length : 0} Courses

diff --git a/src/views/components/common/ScheduleTotalHoursAndCourses.tsx b/src/views/components/common/ScheduleTotalHoursAndCourses.tsx index d7e89207e..4e251cfbc 100644 --- a/src/views/components/common/ScheduleTotalHoursAndCourses.tsx +++ b/src/views/components/common/ScheduleTotalHoursAndCourses.tsx @@ -21,16 +21,28 @@ export default function ScheduleTotalHoursAndCourses({ totalCourses, }: ScheduleTotalHoursAndCoursesProps): JSX.Element { return ( -
+
{`${scheduleName}: `} - - {totalHours} {totalHours === 1 ? 'Hour' : 'Hours'} - - {totalCourses} {totalCourses === 1 ? 'Course' : 'Courses'} +
+ + {totalHours} + {totalHours === 1 ? 'Hour' : 'Hours'} - + + {totalCourses} + {totalCourses === 1 ? 'Course' : 'Courses'} + +
); } From 312cc1e9d7c66b2da3d62137d4f88b3f82c324c4 Mon Sep 17 00:00:00 2001 From: Warith Rahman Date: Wed, 23 Oct 2024 19:40:25 -0500 Subject: [PATCH 03/13] fix: new hour/course styling per discussion i love having 80 different ideas, hopefully after this there's like maybe a tiny commit left to do before this is done.. --- .../components/common/ScheduleDropdown.tsx | 4 +- .../common/ScheduleTotalHoursAndCourses.tsx | 40 ++++++++++--------- 2 files changed, 24 insertions(+), 20 deletions(-) diff --git a/src/views/components/common/ScheduleDropdown.tsx b/src/views/components/common/ScheduleDropdown.tsx index b3c29cfae..ae2a242df 100644 --- a/src/views/components/common/ScheduleDropdown.tsx +++ b/src/views/components/common/ScheduleDropdown.tsx @@ -27,14 +27,14 @@ export default function ScheduleDropdown(props: ScheduleDropdownProps) { <>
- + {(activeSchedule ? activeSchedule.name : 'Schedule').toUpperCase()}:

{activeSchedule ? activeSchedule.hours : 0} HOURS - + {activeSchedule ? activeSchedule.courses.length : 0} Courses

diff --git a/src/views/components/common/ScheduleTotalHoursAndCourses.tsx b/src/views/components/common/ScheduleTotalHoursAndCourses.tsx index 4e251cfbc..86f25be50 100644 --- a/src/views/components/common/ScheduleTotalHoursAndCourses.tsx +++ b/src/views/components/common/ScheduleTotalHoursAndCourses.tsx @@ -21,27 +21,31 @@ export default function ScheduleTotalHoursAndCourses({ totalCourses, }: ScheduleTotalHoursAndCoursesProps): JSX.Element { return ( -
+
{`${scheduleName}: `} -
- - {totalHours} - {totalHours === 1 ? 'Hour' : 'Hours'} - - - {totalCourses} - {totalCourses === 1 ? 'Course' : 'Courses'} - +
+
+ + {totalHours}{' '} + + + + {totalHours === 1 ? 'HOUR' : 'HOURS'} + + +
+
+ + {totalCourses}{' '} + + + + {totalCourses === 1 ? 'COURSE' : 'COURSES'} + + +
); From 50b17fcdad3f2c7459f8e3bc35471aa63747ef0e Mon Sep 17 00:00:00 2001 From: Warith Rahman Date: Wed, 30 Oct 2024 11:20:45 -0500 Subject: [PATCH 04/13] feat(header): added icons to cal header WORK IN PROGRESS --- package.json | 2 ++ pnpm-lock.yaml | 20 +++++++++++++++++++ .../common/ScheduleTotalHoursAndCourses.tsx | 17 ++++++++++------ 3 files changed, 33 insertions(+), 6 deletions(-) diff --git a/package.json b/package.json index 8fcae1f88..b23d34ef6 100644 --- a/package.json +++ b/package.json @@ -59,9 +59,11 @@ "@commitlint/types": "^19.5.0", "@crxjs/vite-plugin": "2.0.0-beta.21", "@iconify-json/bi": "^1.2.1", + "@iconify-json/ic": "^1.2.1", "@iconify-json/iconoir": "^1.2.2", "@iconify-json/material-symbols": "^1.2.4", "@iconify-json/ri": "^1.2.1", + "@iconify-json/streamline": "^1.2.1", "@semantic-release/exec": "^6.0.3", "@sentry/types": "^8.34.0", "@storybook/addon-designs": "^8.0.3", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 9eb4f46a7..4c4eaa33f 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -110,6 +110,9 @@ importers: '@iconify-json/bi': specifier: ^1.2.1 version: 1.2.1 + '@iconify-json/ic': + specifier: ^1.2.1 + version: 1.2.1 '@iconify-json/iconoir': specifier: ^1.2.2 version: 1.2.2 @@ -119,6 +122,9 @@ importers: '@iconify-json/ri': specifier: ^1.2.1 version: 1.2.1 + '@iconify-json/streamline': + specifier: ^1.2.1 + version: 1.2.1 '@semantic-release/exec': specifier: ^6.0.3 version: 6.0.3(semantic-release@24.1.2(typescript@5.6.3)) @@ -914,6 +920,9 @@ packages: '@iconify-json/bi@1.2.1': resolution: {integrity: sha512-wsIWb6bcnBkfN8/2puIIE2ul6NYVjclbE/nI7JZsPnfzBamd3NuRFstXQH9Ckkbrw9eiBTNKwHbH90w3UE5QIg==} + '@iconify-json/ic@1.2.1': + resolution: {integrity: sha512-UjL/bjJP/T5EV881+hTzcfTKVo0KEUjhnMiJcLtPzNgPtU2KZZmRx8BSKKR61H4CN/5FTEbyawGyG0aEt3SwGQ==} + '@iconify-json/iconoir@1.2.2': resolution: {integrity: sha512-ytC2V7WeIHsQSyd5r+Iq/ExNb/yM45iR0jhbKNqFFSWhJvuanfIyuTHH/SQJpPYwV1grGtIx7v+kZ7xIjltdpA==} @@ -923,6 +932,9 @@ packages: '@iconify-json/ri@1.2.1': resolution: {integrity: sha512-xI3+xZHBI+wlhQqd6jRRcLD5K8B8vQNyxcSB43myxNZ/SfXIn7Ny28h0jyPo9e0gT8fGhqx6R5PeLz/UBB8jwQ==} + '@iconify-json/streamline@1.2.1': + resolution: {integrity: sha512-hqNodkjyIHBymkFY3zMip0F/D5yw4qXgwMJCaTF3zlbpQMgNJhY3D2ikTFTDVcTHfCSd6EX6enKXj4Rvu+5hnw==} + '@iconify/types@2.0.0': resolution: {integrity: sha512-+wluvCrRhXrhyOmRDJ3q8mux9JkKy5SJ/v8ol2tu4FVjyYvtEzkc/3pK15ET6RKg4b4w4BmTk1+gsCUhf21Ykg==} @@ -7477,6 +7489,10 @@ snapshots: dependencies: '@iconify/types': 2.0.0 + '@iconify-json/ic@1.2.1': + dependencies: + '@iconify/types': 2.0.0 + '@iconify-json/iconoir@1.2.2': dependencies: '@iconify/types': 2.0.0 @@ -7489,6 +7505,10 @@ snapshots: dependencies: '@iconify/types': 2.0.0 + '@iconify-json/streamline@1.2.1': + dependencies: + '@iconify/types': 2.0.0 + '@iconify/types@2.0.0': {} '@iconify/utils@2.1.33': diff --git a/src/views/components/common/ScheduleTotalHoursAndCourses.tsx b/src/views/components/common/ScheduleTotalHoursAndCourses.tsx index 86f25be50..ff2cf532d 100644 --- a/src/views/components/common/ScheduleTotalHoursAndCourses.tsx +++ b/src/views/components/common/ScheduleTotalHoursAndCourses.tsx @@ -1,6 +1,9 @@ import Text from '@views/components/common/Text/Text'; import React from 'react'; +import ClockIcon from '~icons/ic/baseline-access-time-filled'; +import BookIcon from '~icons/material-symbols/book-2-rounded'; + /** * Props for ScheduleTotalHoursAndCourses */ @@ -22,25 +25,27 @@ export default function ScheduleTotalHoursAndCourses({ }: ScheduleTotalHoursAndCoursesProps): JSX.Element { return (
- - {`${scheduleName}: `} + + {`${scheduleName} `}
-
+
+ {totalHours}{' '} - + {totalHours === 1 ? 'HOUR' : 'HOURS'}
-
+
+ {totalCourses}{' '} - + {totalCourses === 1 ? 'COURSE' : 'COURSES'} From 4c3098edfae9ee48bc7dac47d42bd84edf5a0cf3 Mon Sep 17 00:00:00 2001 From: Warith Rahman Date: Fri, 1 Nov 2024 12:16:18 -0500 Subject: [PATCH 05/13] style: updated layout of header and main popup --- .../components/common/ScheduleDropdown.tsx | 20 +++++--- .../common/ScheduleTotalHoursAndCourses.tsx | 46 ++++++++----------- 2 files changed, 32 insertions(+), 34 deletions(-) diff --git a/src/views/components/common/ScheduleDropdown.tsx b/src/views/components/common/ScheduleDropdown.tsx index ae2a242df..a42ca5a37 100644 --- a/src/views/components/common/ScheduleDropdown.tsx +++ b/src/views/components/common/ScheduleDropdown.tsx @@ -27,16 +27,22 @@ export default function ScheduleDropdown(props: ScheduleDropdownProps) { <>
- + {(activeSchedule ? activeSchedule.name : 'Schedule').toUpperCase()}:

- - {activeSchedule ? activeSchedule.hours : 0} HOURS - - - {activeSchedule ? activeSchedule.courses.length : 0} Courses - + + {activeSchedule ? activeSchedule.hours : 0} + {' '} + + {activeSchedule.hours === 1 ? 'Hour' : 'Hours'} + {' '} + + {activeSchedule ? activeSchedule.courses.length : 0} + {' '} + + {activeSchedule.courses.length === 1 ? 'Course' : 'Courses'} +

diff --git a/src/views/components/common/ScheduleTotalHoursAndCourses.tsx b/src/views/components/common/ScheduleTotalHoursAndCourses.tsx index ff2cf532d..da15d19e8 100644 --- a/src/views/components/common/ScheduleTotalHoursAndCourses.tsx +++ b/src/views/components/common/ScheduleTotalHoursAndCourses.tsx @@ -1,9 +1,6 @@ import Text from '@views/components/common/Text/Text'; import React from 'react'; -import ClockIcon from '~icons/ic/baseline-access-time-filled'; -import BookIcon from '~icons/material-symbols/book-2-rounded'; - /** * Props for ScheduleTotalHoursAndCourses */ @@ -24,32 +21,27 @@ export default function ScheduleTotalHoursAndCourses({ totalCourses, }: ScheduleTotalHoursAndCoursesProps): JSX.Element { return ( -
- - {`${scheduleName} `} +
+ + {`${scheduleName}:`} -
-
- - - {totalHours}{' '} - - - - {totalHours === 1 ? 'HOUR' : 'HOURS'} - - +
+
+
+ + {totalHours} + {' '} + + {totalHours === 1 ? 'Hour' : 'Hours'} +
-
- - - {totalCourses}{' '} - - - - {totalCourses === 1 ? 'COURSE' : 'COURSES'} - - +
+ + {totalCourses} + {' '} + + {totalCourses === 1 ? 'Course' : 'Courses'} +
From 1931d344c58db15330f0e02722aabf0f30ecf6b3 Mon Sep 17 00:00:00 2001 From: Warith Rahman Date: Tue, 5 Nov 2024 00:03:11 -0600 Subject: [PATCH 06/13] fix: updated font and spacing for header and popup --- .../components/common/ScheduleDropdown.tsx | 40 ++++++++++++------- .../common/ScheduleTotalHoursAndCourses.tsx | 28 ++++++++----- 2 files changed, 45 insertions(+), 23 deletions(-) diff --git a/src/views/components/common/ScheduleDropdown.tsx b/src/views/components/common/ScheduleDropdown.tsx index a42ca5a37..6528b775b 100644 --- a/src/views/components/common/ScheduleDropdown.tsx +++ b/src/views/components/common/ScheduleDropdown.tsx @@ -30,20 +30,32 @@ export default function ScheduleDropdown(props: ScheduleDropdownProps) { {(activeSchedule ? activeSchedule.name : 'Schedule').toUpperCase()}: -

- - {activeSchedule ? activeSchedule.hours : 0} - {' '} - - {activeSchedule.hours === 1 ? 'Hour' : 'Hours'} - {' '} - - {activeSchedule ? activeSchedule.courses.length : 0} - {' '} - - {activeSchedule.courses.length === 1 ? 'Course' : 'Courses'} - -

+
+
+ + {activeSchedule ? activeSchedule.hours : 0} + + + {activeSchedule.hours === 1 ? 'Hour' : 'Hours'} + +
+
+ + {activeSchedule ? activeSchedule.courses.length : 0} + + + {activeSchedule.courses.length === 1 ? 'Course' : 'Courses'} + +
+
{open ? : } diff --git a/src/views/components/common/ScheduleTotalHoursAndCourses.tsx b/src/views/components/common/ScheduleTotalHoursAndCourses.tsx index da15d19e8..6489dd935 100644 --- a/src/views/components/common/ScheduleTotalHoursAndCourses.tsx +++ b/src/views/components/common/ScheduleTotalHoursAndCourses.tsx @@ -27,21 +27,31 @@ export default function ScheduleTotalHoursAndCourses({
-
+
{totalHours} - {' '} - + + {totalHours === 1 ? 'Hour' : 'Hours'} - +
-
- +
+ {totalCourses} - {' '} - + + {totalCourses === 1 ? 'Course' : 'Courses'} - +
From fa2eda8b188d30b1551a1d0395dd2bacac0513c0 Mon Sep 17 00:00:00 2001 From: Warith Rahman Date: Tue, 5 Nov 2024 13:43:46 -0600 Subject: [PATCH 07/13] fix: updated cal + popup style details - schedule title is now in normal casing w/ colon removed - last updated on is now entirely deleted from everywhere - hour and course numbers now h3 in calendar ONLY --- src/views/components/PopupMain.tsx | 3 --- src/views/components/calendar/CalendarHeader.tsx | 10 ---------- src/views/components/common/ScheduleDropdown.tsx | 9 +++++++-- .../components/common/ScheduleTotalHoursAndCourses.tsx | 8 ++++---- src/views/components/settings/Settings.tsx | 6 +----- 5 files changed, 12 insertions(+), 24 deletions(-) diff --git a/src/views/components/PopupMain.tsx b/src/views/components/PopupMain.tsx index 999999a8e..3b733d398 100644 --- a/src/views/components/PopupMain.tsx +++ b/src/views/components/PopupMain.tsx @@ -187,9 +187,6 @@ export default function PopupMain(): JSX.Element {
{enableDataRefreshing && (
- - LAST UPDATED: {getUpdatedAtDateTimeString(activeSchedule.updatedAt)} - {/* */} -
- )}
{enableCourseStatusChips && ( diff --git a/src/views/components/common/ScheduleDropdown.tsx b/src/views/components/common/ScheduleDropdown.tsx index 6528b775b..7e5cbdccc 100644 --- a/src/views/components/common/ScheduleDropdown.tsx +++ b/src/views/components/common/ScheduleDropdown.tsx @@ -27,8 +27,13 @@ export default function ScheduleDropdown(props: ScheduleDropdownProps) { <>
- - {(activeSchedule ? activeSchedule.name : 'Schedule').toUpperCase()}: + + {activeSchedule ? activeSchedule.name : 'Schedule'}
diff --git a/src/views/components/common/ScheduleTotalHoursAndCourses.tsx b/src/views/components/common/ScheduleTotalHoursAndCourses.tsx index 6489dd935..0bcd62ec4 100644 --- a/src/views/components/common/ScheduleTotalHoursAndCourses.tsx +++ b/src/views/components/common/ScheduleTotalHoursAndCourses.tsx @@ -22,13 +22,13 @@ export default function ScheduleTotalHoursAndCourses({ }: ScheduleTotalHoursAndCoursesProps): JSX.Element { return (
- - {`${scheduleName}:`} + + {`${scheduleName}`}
- + {totalHours}
- + {totalCourses} {DISPLAY_PREVIEWS && ( -
- - LAST UPDATED: {getUpdatedAtDateTimeString(activeSchedule.updatedAt)} - -
+
Date: Tue, 5 Nov 2024 18:17:30 -0600 Subject: [PATCH 08/13] refactor: changed size for calendar header --- src/views/components/common/ScheduleTotalHoursAndCourses.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/views/components/common/ScheduleTotalHoursAndCourses.tsx b/src/views/components/common/ScheduleTotalHoursAndCourses.tsx index 0bcd62ec4..9bac6c58d 100644 --- a/src/views/components/common/ScheduleTotalHoursAndCourses.tsx +++ b/src/views/components/common/ScheduleTotalHoursAndCourses.tsx @@ -32,7 +32,7 @@ export default function ScheduleTotalHoursAndCourses({ {totalHours} Date: Tue, 5 Nov 2024 18:31:27 -0600 Subject: [PATCH 09/13] refactor: changed ut-black to theme-black --- src/views/components/calendar/CalendarHeader.tsx | 2 +- .../components/common/ScheduleTotalHoursAndCourses.tsx | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/views/components/calendar/CalendarHeader.tsx b/src/views/components/calendar/CalendarHeader.tsx index c4364c1b8..7f4482314 100644 --- a/src/views/components/calendar/CalendarHeader.tsx +++ b/src/views/components/calendar/CalendarHeader.tsx @@ -88,7 +88,7 @@ export default function CalendarHeader({ onSidebarToggle }: CalendarHeaderProps) {/*
); diff --git a/src/views/components/common/ScheduleTotalHoursAndCourses.tsx b/src/views/components/common/ScheduleTotalHoursAndCourses.tsx index 9bac6c58d..4348accd1 100644 --- a/src/views/components/common/ScheduleTotalHoursAndCourses.tsx +++ b/src/views/components/common/ScheduleTotalHoursAndCourses.tsx @@ -26,8 +26,8 @@ export default function ScheduleTotalHoursAndCourses({ {`${scheduleName}`}
-
-
+
+
{totalHours} @@ -40,7 +40,7 @@ export default function ScheduleTotalHoursAndCourses({ {totalHours === 1 ? 'Hour' : 'Hours'}
-
+
{totalCourses} From 7a4561994c6489f0f25c8dbcd11341137e2bac0c Mon Sep 17 00:00:00 2001 From: Warith Rahman Date: Tue, 5 Nov 2024 19:44:22 -0600 Subject: [PATCH 10/13] refactor: remove hiding on small window sizes --- .../components/common/ScheduleDropdown.tsx | 20 ++++--------------- .../common/ScheduleTotalHoursAndCourses.tsx | 10 +++++----- 2 files changed, 9 insertions(+), 21 deletions(-) diff --git a/src/views/components/common/ScheduleDropdown.tsx b/src/views/components/common/ScheduleDropdown.tsx index 7e5cbdccc..183bedbc3 100644 --- a/src/views/components/common/ScheduleDropdown.tsx +++ b/src/views/components/common/ScheduleDropdown.tsx @@ -37,26 +37,14 @@ export default function ScheduleDropdown(props: ScheduleDropdownProps) {
- - {activeSchedule ? activeSchedule.hours : 0} - - + {activeSchedule ? activeSchedule.hours : 0} + {activeSchedule.hours === 1 ? 'Hour' : 'Hours'}
- - {activeSchedule ? activeSchedule.courses.length : 0} - - + {activeSchedule ? activeSchedule.courses.length : 0} + {activeSchedule.courses.length === 1 ? 'Course' : 'Courses'}
diff --git a/src/views/components/common/ScheduleTotalHoursAndCourses.tsx b/src/views/components/common/ScheduleTotalHoursAndCourses.tsx index 4348accd1..27c659810 100644 --- a/src/views/components/common/ScheduleTotalHoursAndCourses.tsx +++ b/src/views/components/common/ScheduleTotalHoursAndCourses.tsx @@ -21,33 +21,33 @@ export default function ScheduleTotalHoursAndCourses({ totalCourses, }: ScheduleTotalHoursAndCoursesProps): JSX.Element { return ( -
+
{`${scheduleName}`}
- + {totalHours} {totalHours === 1 ? 'Hour' : 'Hours'}
- + {totalCourses} {totalCourses === 1 ? 'Course' : 'Courses'} From 77ee74735534b160a94e6770ea9b453efa879177 Mon Sep 17 00:00:00 2001 From: Warith Rahman Date: Tue, 5 Nov 2024 20:24:22 -0600 Subject: [PATCH 11/13] refactor: reduced spacing in popup --- src/views/components/common/ScheduleDropdown.tsx | 2 +- src/views/components/common/ScheduleTotalHoursAndCourses.tsx | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/views/components/common/ScheduleDropdown.tsx b/src/views/components/common/ScheduleDropdown.tsx index 183bedbc3..523b61c48 100644 --- a/src/views/components/common/ScheduleDropdown.tsx +++ b/src/views/components/common/ScheduleDropdown.tsx @@ -30,7 +30,7 @@ export default function ScheduleDropdown(props: ScheduleDropdownProps) { {activeSchedule ? activeSchedule.name : 'Schedule'} diff --git a/src/views/components/common/ScheduleTotalHoursAndCourses.tsx b/src/views/components/common/ScheduleTotalHoursAndCourses.tsx index 27c659810..876214f19 100644 --- a/src/views/components/common/ScheduleTotalHoursAndCourses.tsx +++ b/src/views/components/common/ScheduleTotalHoursAndCourses.tsx @@ -25,7 +25,6 @@ export default function ScheduleTotalHoursAndCourses({ {`${scheduleName}`} -
From 1763598da025693c59c26f8ecad48540d3e1609f Mon Sep 17 00:00:00 2001 From: Warith Rahman Date: Mon, 11 Nov 2024 23:33:03 -0600 Subject: [PATCH 12/13] refactor: updated unocss for small-caps configuration --- src/views/components/common/ScheduleDropdown.tsx | 11 +++-------- .../common/ScheduleTotalHoursAndCourses.tsx | 10 ++++------ src/views/components/settings/Settings.tsx | 1 - unocss.config.ts | 1 + 4 files changed, 8 insertions(+), 15 deletions(-) diff --git a/src/views/components/common/ScheduleDropdown.tsx b/src/views/components/common/ScheduleDropdown.tsx index 523b61c48..73a10c84e 100644 --- a/src/views/components/common/ScheduleDropdown.tsx +++ b/src/views/components/common/ScheduleDropdown.tsx @@ -27,24 +27,19 @@ export default function ScheduleDropdown(props: ScheduleDropdownProps) { <>
- + {activeSchedule ? activeSchedule.name : 'Schedule'}
{activeSchedule ? activeSchedule.hours : 0} - + {activeSchedule.hours === 1 ? 'Hour' : 'Hours'}
{activeSchedule ? activeSchedule.courses.length : 0} - + {activeSchedule.courses.length === 1 ? 'Course' : 'Courses'}
diff --git a/src/views/components/common/ScheduleTotalHoursAndCourses.tsx b/src/views/components/common/ScheduleTotalHoursAndCourses.tsx index 876214f19..af6b509e6 100644 --- a/src/views/components/common/ScheduleTotalHoursAndCourses.tsx +++ b/src/views/components/common/ScheduleTotalHoursAndCourses.tsx @@ -22,8 +22,8 @@ export default function ScheduleTotalHoursAndCourses({ }: ScheduleTotalHoursAndCoursesProps): JSX.Element { return (
- - {`${scheduleName}`} + + {scheduleName}
@@ -33,8 +33,7 @@ export default function ScheduleTotalHoursAndCourses({ {totalHours === 1 ? 'Hour' : 'Hours'} @@ -46,8 +45,7 @@ export default function ScheduleTotalHoursAndCourses({ {totalCourses === 1 ? 'Course' : 'Courses'} diff --git a/src/views/components/settings/Settings.tsx b/src/views/components/settings/Settings.tsx index cefd4362d..66418853b 100644 --- a/src/views/components/settings/Settings.tsx +++ b/src/views/components/settings/Settings.tsx @@ -421,7 +421,6 @@ export default function Settings(): JSX.Element {
{DISPLAY_PREVIEWS && ( -
Date: Mon, 11 Nov 2024 23:58:23 -0600 Subject: [PATCH 13/13] style: changed variant + className order --- src/views/components/common/ScheduleDropdown.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/views/components/common/ScheduleDropdown.tsx b/src/views/components/common/ScheduleDropdown.tsx index 73a10c84e..cb28ba137 100644 --- a/src/views/components/common/ScheduleDropdown.tsx +++ b/src/views/components/common/ScheduleDropdown.tsx @@ -33,13 +33,13 @@ export default function ScheduleDropdown(props: ScheduleDropdownProps) {
{activeSchedule ? activeSchedule.hours : 0} - + {activeSchedule.hours === 1 ? 'Hour' : 'Hours'}
{activeSchedule ? activeSchedule.courses.length : 0} - + {activeSchedule.courses.length === 1 ? 'Course' : 'Courses'}