Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue components are not included on first build (OSOE-892) #145

Open
wAsnk opened this issue Aug 6, 2024 · 4 comments
Open

Vue components are not included on first build (OSOE-892) #145

wAsnk opened this issue Aug 6, 2024 · 4 comments

Comments

@wAsnk
Copy link
Member

wAsnk commented Aug 6, 2024

Building a clean repo will result in missing vue components in the Lombiq.VueJs.dll and also it will do the same in projects that are using this module.

Repo steps:

  1. Delete wwwroot folder, or use a clean repository.
  2. Build the project
  3. The Lombiq.VueJs.dll is missing vue folder and the vue components.
  4. Build the project again (The wwwroot already contains all the compiled scripts for vue component)
  5. The Lombiq.VueJs.dll has all the components.

I used ILSpy to check dll resources.

The vue components should be compiled to the wwwroot folder before the assembly and the Lobiq.VueJs.dll is created.

Jira issue

@github-actions github-actions bot changed the title Vue components are not included on first build Vue components are not included on first build (OSOE-892) Aug 6, 2024
@Piedone
Copy link
Member

Piedone commented Aug 6, 2024

You included a solution here: #144 Isn't that suitable long-term?

@sarahelsaig
Copy link
Member

Sounds like a build order problem?

@wAsnk
Copy link
Member Author

wAsnk commented Aug 6, 2024

You included a solution here: #144 Isn't that suitable long-term?

No, that only moves the script files, but it does not solve the issue with vue components. The vue component are in the Assets/Scripts/VueComponents folder, and they require a special compilation process.

Sounds like a build order problem?

Yes

@Piedone
Copy link
Member

Piedone commented Aug 6, 2024

And/or the same thing that we solved in Node.js Extensions somehow (check targets and props files), since static files built be NE weren't included in the assembly either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants