Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an endpoint on backend to clear an instance's console buffer #299

Open
Tracked by #267
Ynng opened this issue Jul 13, 2023 · 2 comments · May be fixed by #408
Open
Tracked by #267

Add an endpoint on backend to clear an instance's console buffer #299

Ynng opened this issue Jul 13, 2023 · 2 comments · May be fixed by #408
Assignees
@CheatCod
Labels
core issue relating to the backend (core) good first issue Good for newcomers

Comments

@Ynng
Copy link
Member

Ynng commented Jul 13, 2023

No description provided.

@Ynng Ynng mentioned this issue Jul 13, 2023
Closed
@CheatCod CheatCod added good first issue Good for newcomers core issue relating to the backend (core) labels Jul 24, 2023
@Ynng Ynng added this to Lodestone Jul 27, 2023
@github-project-automation github-project-automation bot moved this to 🗃 Draft/Backlog in Lodestone Jul 27, 2023
@CheatCod
Copy link
Member

I just realized clearing the buffer will clear it for ALL users, I'm not sure if that's the behaviour we want

@Ynng
Copy link
Member Author

Ynng commented Aug 1, 2023

I think that's reasonable

Ynng added a commit that referenced this issue Aug 16, 2024
@Ynng
Add an endpoint to clear an instance's console buffer
c3bb247 
Fixes #299

Add an endpoint to clear an instance's console buffer by clearing the circular buffer within the global app state buffer.

* **core/src/lib.rs**
  - Add a method `clear_console_buffer` to the `AppState` struct to clear the console buffer for a specific instance.

* **core/src/handlers/events.rs**
  - Add a new function `clear_console_buffer` to handle the request to clear the console buffer.
  - Add a new route `/instance/:uuid/console/clear` to handle the request to clear the console buffer.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/Lodestone-Team/lodestone/issues/299?shareId=XXXX-XXXX-XXXX-XXXX).
@Ynng Ynng linked a pull request Aug 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CheatCod CheatCod

Labels
core issue relating to the backend (core) good first issue Good for newcomers
Projects
Lodestone
Status: 🗃 Draft/Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add an endpoint to clear an instance's console buffer Lodestone-Team/lodestone
2 participants
@Ynng @CheatCod