Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor database structure of secret objects #528

Open
dorthrithil opened this issue Nov 17, 2024 · 0 comments
Open

Refactor database structure of secret objects #528

dorthrithil opened this issue Nov 17, 2024 · 0 comments
Labels
needs design Feature is not fully designed and needs more design work before implementation can start refactoring Refactor existing code to make it better

Comments

@dorthrithil
Copy link
Contributor

We have: lines, areas, sectors, crags that can be secret. Then we have tags that also have the secret property as I couldn't get an efficient filter to work for the gallery.

My idea to solve this would be a new table only holding the secret property which can then be used for all objects that can be secret. Also we could then write a reusable filter for all the places it is needed. Needs definetely some more thoughts.
@dorthrithil dorthrithil added refactoring Refactor existing code to make it better needs design Feature is not fully designed and needs more design work before implementation can start labels Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs design Feature is not fully designed and needs more design work before implementation can start refactoring Refactor existing code to make it better
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dorthrithil