Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More links #490

Open
BlobbyBob opened this issue Oct 28, 2024 · 1 comment
Open

More links #490

BlobbyBob opened this issue Oct 28, 2024 · 1 comment
Labels
enhancement Improves existing features

Comments

@BlobbyBob
Copy link
Collaborator

Currently, a lot of the internal navigation is handled by click event handlers. Ideally, all of those references should be proper <a href> links, so you can use browser features like "Open in a new tab" or "Copy link". To keep the SPA feeling, normal click events should ignore the default browser link behavior and replace it with internal routing.

This works already fine for the breadcrumb and the line links for topo images but not for the main menu and crag/sector/area lists.

@BlobbyBob BlobbyBob added the enhancement Improves existing features label Oct 28, 2024
@dorthrithil
Copy link
Contributor

In the gallery branch I just implemented the entityLink pipe. You can use it like so <a [routerLink]="entity | entityLink">. Currently it supports creating links for Lines, [...], Crags and Users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves existing features
Projects
None yet
Development

No branches or pull requests

2 participants