-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repeated Command will take in second command instead of throwing error message #1
Comments
Team's ResponseThis is an issue that we have been thinking about for quite a while. We were conflicted with whether or not to allow a correct command to be executed if it is followed by additional strings at the back. Initially we decided to allow it so if the substring at the front is of a legitimate command with the correct format, we just ignore the strings at the back. We thought that it would be more convenient for users as some user typo after a command will be ignored. However, since this issue has been raced, we have decided to change our implementation of it and not allow commands to be executed if there are additional strings at the back. Items for the Tester to Verify❓ Issue severityTeam chose [
Reason for disagreement: The severity should be medium as it affects majority of the users who think that they could implement multiple commands at once since it is not stated in the UG or DG that users shoud not implement multiple commands at once. Another issue has been raised with the same type of error (#4 Repeated command will take in new command instead of throwing error). In that issue, only the first command will be carried out if there is multiple commands. However, in this issue (#1 Repeated Command will take in second command instead of throwing error message), only the last command will be carried out if there is multiple commands. Hence, there is definitely error in the logic. |
When typing in repeated command, e.g. budget b/1000 rc/ budget b/20 rc/, the app will take in the second command and ignore the first command.
The text was updated successfully, but these errors were encountered: