Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced options #15

Open
jvyden opened this issue Aug 24, 2023 · 10 comments
Open

Advanced options #15

jvyden opened this issue Aug 24, 2023 · 10 comments
Labels
enhancement New feature or request

Comments

@jvyden
Copy link
Member

jvyden commented Aug 24, 2023

Ability to manually set if digest key should be patched, and other options if we implement any.

Low priority unless there is demand.

@jvyden jvyden added the enhancement New feature or request label Sep 19, 2023
@Arcadius2006
Copy link

note: there is demand

@Beyley
Copy link
Member

Beyley commented Jan 27, 2024

im curious what the sudden need for this is?

@speedyman08
Copy link

Multiple people have tried to patch LBP1 to lighthouse with Refresher, that wouldn't work though as beacon uses the original digest key, but refresher will set the key to "LbpPrivateServer" or something (i dont remember what the default was)

@Arcadius2006
Copy link

the default is "CustomDigestKey" (imaginative, i know)

@Arcadius2006
Copy link

another usecase is making some prototypes work with server aswell, since they dont always share the same digest key as the final game

@Beyley
Copy link
Member

Beyley commented Jan 27, 2024

Multiple people have tried to patch LBP1 to lighthouse with Refresher, that wouldn't work though as beacon uses the original digest key, but refresher will set the key to "LbpPrivateServer" or something (i dont remember what the default was)

refresher will not patch the digest key unless autodiscover is used.

another usecase is making some prototypes work with server aswell, since they dont always share the same digest key as the final game

we dont really support prototypes anyway, so thats not a concern

@jvyden
Copy link
Member Author

jvyden commented Jan 28, 2024

another usecase is making some prototypes work with server aswell, since they dont always share the same digest key as the final game

Patching the digest key to CustomServerDigest is meant to resolve this by unifying everything patched to one digest key. If you mean getting prototypes working on Lighthouse, then that's their issue, not ours, because we've already solved that problem.

@jvyden
Copy link
Member Author

jvyden commented Jan 28, 2024

Multiple people have tried to patch LBP1 to lighthouse with Refresher, that wouldn't work though as beacon uses the original digest key

As Beyley says, this will only happen after a successful AutoDiscover negotiation where the server specifies usesCustomDigestKey as true (as LBR does here)

What's likely happening is you're attempting to use Refresher after already having patched your game to Refresh. In this scenario, the digest key has already been modified to CustomServerDigest from the original and since Refresher doesn't know the original key it can't change it back.

This can be solved by reverting to the original backup of the EBOOT taken when you first patch LBP by simply clicking the button to do so in the patcher's UI. I recognize that this is bad UX so I'll open an issue about using the backup for patches by default.

@jvyden
Copy link
Member Author

jvyden commented Jan 28, 2024

Just as a note, another solution would technically be for Lighthouse to start accepting the CustomServerDigest key which would also fix prototypes, but I don't really see this happening and it ignores the root cause anyways.

@jvyden
Copy link
Member Author

jvyden commented Jan 28, 2024

Created #49 to track that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants