Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location id param #66

Open
ZikaCodez opened this issue Sep 4, 2022 · 1 comment
Open

Location id param #66

ZikaCodez opened this issue Sep 4, 2022 · 1 comment

Comments

@ZikaCodez
Copy link

Adding a locationId param to createServer is a good idea to allow choosing a random allocation id instead of setting a default allocation for each server.

@Linux123123
Copy link
Owner

Linux123123 commented Sep 4, 2022

The only way of providing the option to choose a random allocation is to use a deployment object. It requires a bit more information than just the location ID. At the start of the library, it was how I had it implemented, but it had issues.

For example, I found out that it validates the disk space and memory used on the node, and if it exceeds the limit it fails. The normal server creation (like it is implemented now) doesn't check that.

Of course, I am not against using deployment objects, so I can add it as an optional parameter, for the createServer method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants