Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global degree does not change when changing significant edge value #81

Open
MeeshCompBio opened this issue Feb 5, 2018 · 2 comments
Open

Comments

@MeeshCompBio
Copy link
Contributor

The global degree of genes are always representative of a z-score of 3, it should update when you change the significant edge score.

In [69]: cob = co.COB("W2691")                                                                                                                                                                                     [LOG] Mon Feb  5 16:33:41 2018 - Loading Expr table                                                                                                                                                                [LOG] Mon Feb  5 16:33:41 2018 - Building Expr Index                                                                                                                                                               [LOG] Mon Feb  5 16:33:41 2018 - Loading RefGen                                                                                                                                                                    [LOG] Mon Feb  5 16:33:41 2018 - Building Indices                                                                                                                                                                  [LOG] Mon Feb  5 16:33:41 2018 - Loading Coex table                                                                                                                                                                [LOG] Mon Feb  5 16:33:44 2018 - Loading Global Degree                                                                                                                                                             [LOG] Mon Feb  5 16:33:44 2018 - Loading Clusters                                                                                                                                                                  [LOG] Mon Feb  5 16:33:44 2018 - Building Indices
In [70]: Gene = cob.refgen.from_id("TRAESCS3D01G246000")
In [71]: cob.global_degree(Gene)
Out[71]: 120
In [72]: len(cob.neighbors(Gene, return_gene_set=True))
Out[72]: 120 
In [73]: cob.set_sig_edge_zscore(2.5)
In [76]: cob.global_degree(Gene)
Out[76]: 120
In [77]: len(cob.neighbors(Gene, return_gene_set=True))
Out[77]: 902
@schae234
Copy link
Member

This is a mess right now, the state of the z-score threshold is not well described. Question: Should updating the z-score threshold influence the underlying database at all? I.e. if you set z-scrore to 4 should that modify the coex database table so there is one point of truth? If another instance of the network is started, should it see that the z-score cutoff is 4? This seems easiest to implement but it also restricts concurrency, I've run analyses where I've had 4 different instances of camoco running to test the effects of cutoffs. Ideally we would be able to do this, but it makes the implementation a little harder!

I think we should have two cutoffs. One that gets calculated during co-expression and another that you can slide around and only affect the current instance of the network. Thoughts?

@MeeshCompBio
Copy link
Contributor Author

MeeshCompBio commented Sep 5, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants