Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download/upload to LinDA Workbench all rows #20

Open
dipapaspyros opened this issue Jun 17, 2015 · 3 comments
Open

Download/upload to LinDA Workbench all rows #20

dipapaspyros opened this issue Jun 17, 2015 · 3 comments
Assignees

Comments

@dipapaspyros
Copy link
Contributor

At this point, only the first 10 rows seem to be available when I try to download as a file or create a datasource at the end of the transformation

bbrand84 added a commit that referenced this issue Jul 17, 2015
bbrand84 added a commit that referenced this issue Jul 17, 2015
@bbrand84
Copy link
Contributor

works

@dipapaspyros
Copy link
Contributor Author

In the online version, all lines of the CSV/Excel file are loaded in the browser in each step. This makes the engine unusable for anything but really small files (I experienced serious performance issues with a 44 KB CSV file).
I would propose the following workflow:

  • When the user uploads the file, all rows are saved on server side (preferably not in the Session, as this would render the server unusable in real world scenarios with multiple excel files at the same time).
  • The user is then presented in each step with a small file preview (e.g 10 rows).
  • When the transformation is finally created, it will be applied in the whole file. As a result the overhead from large files will only exist when the actual transformation occurs, and not in every step of the workflow.
    Generally, I believe that for production the whole file should never be in (server) memory at once if it's over a certain limit (e.g 10 MB)

@dipapaspyros dipapaspyros reopened this Jul 28, 2015
@bbrand84
Copy link
Contributor

The performance issues, which I think occured mainly in the object step, were resolved. I tried the 44k asthma observations file. But I'm still working on a better performance in this step.

But yes, the whole file is delivered to the frontend in every step since we calculate everything live in the frontend for better ux. I will see if theres room for optimization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants