monitor and restart Logger process #291
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
===================================
- Coverage 95% 95% -0%
===================================
Files 19 19
Lines 1244 1263 +19
===================================
+ Hits 1182 1197 +15
- Misses 62 66 +4 |
|
@lantiga could you please do an architecture review here? Or do you have a suggestion to handle this in a different way? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Fixes #289
Loggers can stuck while processing and queue will pile up. This PR tries to resolve that by detecting stuck loggers
@lantiga please let me know what do you think about this approach?
TODO:
What does this PR do?
This PR introduces a Process monitor for Logger process and restart the process if a Logger is stuck. This prevents the logger queue from piling up.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃