Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case when Logger.process is stuck #289

Open
aniketmaurya opened this issue Sep 23, 2024 · 0 comments
Open

Handle case when Logger.process is stuck #289

aniketmaurya opened this issue Sep 23, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@aniketmaurya
Copy link
Collaborator

aniketmaurya commented Sep 23, 2024

If process gets stuck here (e.g. a POST request hangs) for one of the loggers, logging hangs for all loggers. This will also cause queue to grow unbounded.

Unfortunately fixing this requires running process in separate processes.

A possible solution for the unbounded problem is having a loop that gets elements from the queue into a local deque (this could happen in a thread), from which process grabs items. This would help also fanning out to multiple loggers.

I don't want to necessarily complicate things right now, just calling this out because it's likely to happen.

Originally posted by @lantiga in #284 (comment)

@aniketmaurya aniketmaurya self-assigned this Sep 23, 2024
@aniketmaurya aniketmaurya added the enhancement New feature or request label Sep 23, 2024
@aniketmaurya aniketmaurya changed the title If process gets stuck here (e.g. a POST request hangs) for one of the loggers, logging hangs for all loggers. This will also cause queue to grow unbounded. Handle case when Logger.process is stuck Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant