cannot access local variable 'theme' where it is not associated with a value

[goldyfruit]

During the ovos-phal service start, I can see an error relates to this plugin.

ovos_phal           | 2023-04-06 10:44:07.221 - OVOS - ovos_PHAL_plugin_color_scheme_manager:provide_theme:75 - ERROR - cannot access local variable 'theme' where it is not associated with a value

[NeonDaniel]

Looks like this will happen if there's no theme file (https://github.com/OpenVoiceOS/ovos-PHAL-plugin-color-scheme-manager/blob/dev/ovos_PHAL_plugin_color_scheme_manager/__init__.py#L55-L62).

@AIIX woud it make sense to return a default theme, or handle no theme file with a debug or info log instead of logging an error?

[AIIX]

Default themes json files are installed by ovos shell, so there will always be default themes installed, the image / platform needs to provide a default "OvosTheme" config file in /etc/xdg with one of the themes selected.