Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline dedup process as part of the photo scan #1158

Open
sefininio opened this issue Feb 10, 2024 · 4 comments
Open

Streamline dedup process as part of the photo scan #1158

sefininio opened this issue Feb 10, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@sefininio
Copy link

As described in the Discord thread message, the dedup via django admin fails for very large photo collections. So, a more robust solution is required:

Option A:

  • Add another button in the UI that causes a scan like process, that runs over all photos and dedupes faces
    Option B:
  • Have the dedup operation part of the scan (so when scanning a photo, the last step is the dedup)
  • Optionally, extend the above and add a checkbox that defaults to off - and only if it is checked, the scan will do the dedup as well (kinda opt-in and not the default)
@sefininio sefininio added the enhancement New feature or request label Feb 10, 2024
@derneuere
Copy link
Member

I wrapped the Django admin task in an AsyncTask, which means that it should work now even with large collections. Would be great if you could test it :)

@sefininio
Copy link
Author

sefininio commented Apr 14, 2024

Hi,
Sorry for the late reply...

I tried on 2024w14p1 but no change... Is it merged?

@sefininio
Copy link
Author

Hey @derneuere , testing on 2024w14p1 made no difference. Clicking on "Select all 91465 photos" does nothing

@derneuere
Copy link
Member

Yes, it was merged, but apparently it does not work yet. Will have to create more tests for it, but do not have the time for that atm :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants