Support bloom filters in lists/nested columns #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shannonwells
commented
Nov 21, 2023
|
|
||
| bloomFilters = await reader.getBloomFiltersFor(["name", "quantity"]); | ||
| it('writes bloom filters for stock,warehouse', async () => { |
There was a problem hiding this comment.
test a plain nested column bloom filter.
shannonwells
commented
Nov 21, 2023
| }); | ||
| describe("a simple schema with a nested list", () => { |
There was a problem hiding this comment.
tests for a bloom filter for a nested list column.
shannonwells
changed the title
wilwade
approved these changes
Nov 22, 2023
Yes Co-authored-by: Wil Wade <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Could not create and read bloom filters for a nested list.
Solution
For bloom filters, treat column names as the full path and not just the first part of the path in the schema.
Closes #98
In the course of implementing this I ran across a couple of issues which are added (#104 #103 )
with @rlaferla
Change summary:
Steps to Verify: