-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edge / Windows 10 / Surface Pro 3 issue: 'save and continue' button is inactive #838
Comments
This also seems to be an issue with other browsers e.g. Safari on MacOS, Firefox on MacOS? |
Hi Mia, I didn't manage to reproduce the bug with Edge and other browsers on windows 10. We should have access to a Surface Pro for testing next week or the following. In the meantime if you have more details about the bug it might be very helpful, e.g.:
|
Hi @geoffroy-noel-ddh, thanks for looking into this! It was reported by a visitor, and I've asked if they can supply more information over email or on this issue. |
Thanks @mialondon was your second message from 17 Jan also relaying issue reported by the same user? |
I've tested a few date transcriptions this morning with Edge on a Surface 4 Pro. I could not reproduce the issue. If you manage to obtain enough details (see above) to reproduce that would be very helpful as I'm afraid, without them, we might not be able to witness it. |
@geoffroy-noel-ddh which volumes did you try it on? I could ask on twitter for any Surface Pro users to try that (or another new one that actually works). I got an out of office from the person who originally reported it... |
Could you provide a link? It doesn't ring a bell offhand. |
I meant this message about the same issue appearing on other devices and browsers. I did the tests on the volume I repaired last week, the first on from the current "Take Part" list: https://www.libcrowds.com/collection/playbills/projects/164/iiif-annotation |
It's so good to see a working task again! I've tweeted to see if anyone can report bugs. |
Yes, it's really nice to see it working again. Talking of which, when you have time, I'd be very curious to know how the instructions I left in the related ticket (#843) will work for you. Unless I overlooked something I believe you should be able to repair the other volumes. |
I was going to talk to @harryjmoss about blocking out a good chunk of time to work through them together. I'm in and out of the office for events at the moment, and http://livingwithmachines.ac.uk/ takes up most of the rest of my time. |
No problem. In case that helps, any of your colleagues with admin access to Libcrowds backend should also be able to run through the documented process. When that happens, I'd recommend you try with a single volume and project first to see how it goes and report any problem or question on github/email if you get stuck. |
I've just tried on my Mac (10.14.3) at home and the 'Save and continue' button isn't active on Firefox 67.0.4. I wasn't logged in. It also didn't work on Safari 12.0.3, not logged in. |
Thanks Mia, I can now reproduce it systematically with any browser. It looks like the two necessary conditions are: not being logged in & going to libcrowds for the first time after starting the browser. I should be able to look into this bug next week, when I'm back from holidays. Mia, if you have time could you please check if following temporary work-around works for you?
Technical notes (for developers) How to reproduce this systematically:
Observations:
|
Thanks! Unfortunately I'm not now home with my mac until Sunday but I'll try it then. |
Hi @mialondon this bug was caused by the resolution of #637 #627. The cookie consent bar had been made transparent and therefore kept obstructing the other controls at the bottom of the page. I've completely hidden the cookie bar on the annotation page. I believe this should also resolve the issues found on Surface Pro, etc. but please let us know if they still occur. This fix, like the others, are in the "2019-fixes" branch on github. Please test it before deploying live and let us know if you find any problem or if you have any question. |
Fixes going live now, thanks to @harryjmoss , so we should be able to confirm soon. |
I've merged the fixes (and one clearing up the travis CI build error) with the master branch, which is now running on the live site! This also includes an automatic security update detailed here. |
Reported via email:
I am writing to report an issue with the ‘Save and Continue’ button on the ‘In the Spotlight’ project page available on the LibCrowds website.
When the ‘Theatre Royal, Bristol’ section of the project is accessed in the Edge browser on Windows 10 on a Surface Pro 3 tablet, the ‘Save and Continue’ button at the bottom of the record page appears to be inactive; I have therefore found it impossible to submit a title transcription and move on to the next record.
The text was updated successfully, but these errors were encountered: