Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll: should the location directory be created recursively? #7

Open
vweevers opened this issue Mar 11, 2022 · 2 comments
Open

Poll: should the location directory be created recursively? #7

vweevers opened this issue Mar 11, 2022 · 2 comments
Labels
poll Poll

Comments

@vweevers
Copy link
Member

Follow-up for #6.

In the following example, should the location directory be created recursively? Such that, if the foo directory does not exist, it will be created (on open) rather than yielding an error?

const db = new ClassicLevel('foo/bar')

Creating it recursively is the current behavior of classic-level (and new compared to leveldown) which may break expectations given typical filesystem behavior, or it could be a convenient feature, if the database is considered to abstract away the filesystem.

React with thumbs up to create the directory recursively, react with thumbs down to yield an error. This question is about what the default behavior should be, so I'm purposefully not including a poll option to make either behavior opt-in.

@vweevers vweevers added the poll Poll label Mar 11, 2022
@vweevers vweevers added this to Level Mar 11, 2022
@vweevers vweevers moved this to Backlog in Level Mar 11, 2022
@vweevers
Copy link
Member Author

@juliangruber Could you please check that the above text is not biased towards my personal preference?

@juliangruber
Copy link
Member

Thank you for asking :) I think the text is fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
poll Poll
Projects
Status: Backlog
Development

No branches or pull requests

2 participants