Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run tests in the browser using e.g. zuul #123

Closed
ralphtheninja opened this issue Sep 4, 2017 · 14 comments · Fixed by #221
Closed

run tests in the browser using e.g. zuul #123

ralphtheninja opened this issue Sep 4, 2017 · 14 comments · Fixed by #221
Labels
enhancement New feature or request

Comments

@ralphtheninja
Copy link
Member

see #93 (similar setup to what memdown does)

@ralphtheninja ralphtheninja self-assigned this Sep 4, 2017
@ralphtheninja ralphtheninja added the enhancement New feature or request label Sep 4, 2017
@vweevers
Copy link
Member

vweevers commented Oct 2, 2017

We'll need to create subaccounts in Sauce Labs for this. Currently memdown uses the main level-ci account, which is my mistake. I learned that an account is implicitly linked to a project, because you get tests, settings, access keys and badges per account. So two projects shouldn't share the same account. But they cán share the same parent account, which allows admins to manage all subaccounts.

It's a bit painful that each (sub)account has to have a unique email address. We can create additional gmails and forward them. Or perhaps it's time to have proper @leveldb.org addresses.

Our Sauce Labs account structure will be something like:

  • level-ci
    • sub: memdown
    • sub: abstract-leveldown

@ralphtheninja ping me when you get around to this, I'll help.

@vweevers
Copy link
Member

@ralphtheninja It turns out that you can have only 1 subaccount, and it isn't public. Not all that useful.

So we'll need separate Sauce Labs accounts for each repo. We can however reuse our gmail address, with aliases. E.g. for the memdown account we'll use leveldb.org+memdown@, for abstract-leveldown we use leveldb.org+abstract.leveldown@, etc.

@vweevers
Copy link
Member

WIP in the airtap branch. Found that tests are failing in IE because we use class in our tests:

class Test extends AbstractLevelDOWN {}

Which was necessary for TypeScript tests. We can remove that now, and revert to prototype.

@vweevers
Copy link
Member

Everything else is passing. Chrome, firefox, edge, iphone and android.

@ralphtheninja
Copy link
Member Author

Everything else is passing. Chrome, firefox, edge, iphone and android.

Awesome!

@ralphtheninja ralphtheninja removed their assignment May 12, 2018
@vweevers
Copy link
Member

vweevers commented May 12, 2018

IE11 is passing now, but IE9 fails on const (screenshot from Sauce Labs):

image

@vweevers
Copy link
Member

Usage of IE9 is 0.12% though. IE9 does not have IndexedDB, so level-js is not gonna work anyway. PouchDB targets IE10+. We don't target IE9 in memdown anymore. The only remaining alternative for IE users, localstorage-down, is heavily outdated. I don't plan on supporting IE9 in my fork, webstorage-down.

Shall we officially drop IE9?

@vweevers
Copy link
Member

That still leaves IE10, which also doesn't support const.

@ralphtheninja
Copy link
Member Author

ralphtheninja commented May 12, 2018

Shall we officially drop IE9?

I wouldn't mind dropping it.

That still leaves IE10, which also doesn't support const.

We can just drop const. But maybe we have problems with const in other modules?

@vweevers
Copy link
Member

But maybe we have problems with const in other modules?

Probably. Another reason for adding browser tests across the board :)

@vweevers
Copy link
Member

Found usage of const in levelup (only in tests, benchmarks and readme code though), level-packager and level-ttl.

@vweevers
Copy link
Member

Added levelup and level-packager to the list in Level/community#18.

@ralphtheninja
Copy link
Member Author

Probably. Another reason for adding browser tests across the board :)

I meant dependencies as well, which should also be a problem right?

@vweevers
Copy link
Member

Could be, most likely in devDependencies. We'll find out soon enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants