Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome 40 and Samsung pinyin keyboard causes double entry #3

Open
cyph84 opened this issue May 6, 2019 · 2 comments
Open

Chrome 40 and Samsung pinyin keyboard causes double entry #3

cyph84 opened this issue May 6, 2019 · 2 comments

Comments

@cyph84
Copy link

cyph84 commented May 6, 2019

Happens only on Samsung keyboard on a Galaxy Tab E. Google pinyin keyboard seems to be ok.

Fixed by commenting out

event.target.value = userInputValue

Tested on Safari iOS and chrome 74 with that line commented out and seems to work. Why was there a need to set the value back into the text field.

@LeoEatle
Copy link
Owner

LeoEatle commented May 6, 2019

Thank you for your found.
What is the meaning of double entry? Is it meaning when we select one character it show up two?
If that's the case, I don't quite understand the cause of it.

But yes, you are right about this line event.target.value = userInputValue. I really don't understand why I add this 😂. Maybe for not modifying event.target.value. We can just remove it.

If you have time, you can send a PR. Or I'll fix it these days.

@cyph84
Copy link
Author

cyph84 commented May 17, 2019

After selecting a candidate character. Two characters appear in the text field.

Here is a video: https://photos.app.goo.gl/fjThXRtNjKe71unn7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants