Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@community(@instances) that are non exising not correctly handled #798

Open
MV-GH opened this issue Jun 21, 2023 · 3 comments
Open

@community(@instances) that are non exising not correctly handled #798

MV-GH opened this issue Jun 21, 2023 · 3 comments
Labels
4 - medium/high priority Issue needs to be fixed soon, does not break core functionality bug Something isn't working

Comments

@MV-GH
Copy link
Collaborator

MV-GH commented Jun 21, 2023

Jerboa Version
Latest from main

Describe the bug
Clicking on a community that doesnt exist still tries to open a view for that community but then gives an error text and the scroll is than frozen, not sure what it is even displaying. It should either not redirect to that community and say community doesnt exist. or like a templatish thing with default image that community name and some text that says this community doesnt exist yet.

To Reproduce
Click on a @community that doesnt exist yet.

Video of the problem

studio64_RggmIodovX.mp4

Unrelated (i think) this community actually exists, https://lemmy.ca/c/trippinthroughtime

@MV-GH MV-GH added the bug Something isn't working label Jun 21, 2023
@twizmwazin twizmwazin added the 4 - medium/high priority Issue needs to be fixed soon, does not break core functionality label Jun 22, 2023
@Kartoffelsaft
Copy link

I've got the same issue trying to connect to https://lemmy.world/c/oldschoolminecraft (long press -> open in external app because it doesn't appear in search).

"Non-existent" isn't how I'd word it because these communities definitely do exist, yet I can't think of another way to describe the issue. "Unknown" maybe?

@ZJouba
Copy link
Contributor

ZJouba commented Aug 8, 2023

What is the intended behavior when an instance isn't federated with the instance in the link i.e. you cannot search for trippinthroughtime from voyager but you can from lemmy.one?

https://lemmy.one/api/v3/community?name=trippinthroughtime%40lemmy.ca
{"community_view":{"community":{"id":8060,"name":"trippinthroughtime","
https://voyager.lemmy.ml/api/v3/community?name=trippinthroughtime%40lemmy.ca
{"error":"couldnt_find_community"}

@MV-GH
Copy link
Collaborator Author

MV-GH commented Aug 8, 2023

The easiest way to handle, clicking on a community that is not known yet to that instance. Would be to open it as usual, when it apistate fails (that error state), check error_msg, does it match with the above error, display a template holder community with some text in the body that says, This community does not exist or is not known yet to this instance. (like most reddit apps)

A future enhancement would be to check if the community actually exists and if so give the option to subscribe/or the action lemmy does to make that community known

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - medium/high priority Issue needs to be fixed soon, does not break core functionality bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants