Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Community, Instance, and User blocks to user settings #682

Open
jeanflajeunesse opened this issue Jun 15, 2023 · 4 comments
Open

Add Community, Instance, and User blocks to user settings #682

jeanflajeunesse opened this issue Jun 15, 2023 · 4 comments
Labels
3 - medium priority This issue needs to be considered, but may not be a priority for the next release enhancement New feature or request

Comments

@jeanflajeunesse
Copy link

  • [x ] Did you check to see if this issue already exists?
  • [x ] Is this only a single feature request? Do not put multiple feature requests in one issue.
  • [ x] Is this a question or discussion? Don't use this, use https://lemmy.ml/c/jerboa

** Describe the feature request below **

It appears theres no way in the app to unblock a community. Blocked communities should be listed somewhere with the option to unblock and/or blocked communities should have their block button replaced with unblock.

@jeanflajeunesse jeanflajeunesse added the enhancement New feature or request label Jun 15, 2023
@twizmwazin twizmwazin added the 3 - medium priority This issue needs to be considered, but may not be a priority for the next release label Jun 15, 2023
@Schoolkid1
Copy link

Are you talking about a moderator function here or an user option?

@jeanflajeunesse
Copy link
Author

A user option

@0hCome0n
Copy link

To clarify, when you block a community, even if you manage to navigate back to that community again (say, through your inbox) the "block community" option remains and is not replaced with an unblock option. Hitting the button anyway just tries to block the already blocked community and nothing interesting happens.

At the very least, an initial fix of changing that button to an unblock button just as the web-interface does should be prioritized over creating a space for your blocked communities list. I do agree that list should also happen eventually.

Screenshot_20230622-215702~2

@Schoolkid1
Copy link

Schoolkid1 commented Aug 9, 2023

I want to push the following code but i cannot test it right from my pc. Can some one check if this would fix the issue?

var isCommunityBlocked = false
// I added the var to keep track if something is blocked I could not find a tracker for it in the existing code

           onBlockCommunityClick = {
                account?.also { acct ->
                    communityViewModel.blockCommunity(
                        account = acct,
                        ctx = ctx,
                    )isCommunityBlocked = true
                } else {
                // Here i added the unblock option
                communityViewModel.unblockCommunity(account = acct, ctx = ctx)
                isCommunityBlocked = false
            }

Schoolkid1 pushed a commit to Schoolkid1/jerboa that referenced this issue Aug 11, 2023
changed the code to make it valid.
Schoolkid1 pushed a commit to Schoolkid1/jerboa that referenced this issue Aug 13, 2023
Changed the parameters, created function and values
Schoolkid1 pushed a commit to Schoolkid1/jerboa that referenced this issue Aug 13, 2023
Rechecked all possible parameters, values, functions and API's for possible needs of change and errors. After tweaking I hope the code will be sufficient
Schoolkid1 pushed a commit to Schoolkid1/jerboa that referenced this issue Aug 13, 2023
Changed document name (caused conflict)
Schoolkid1 pushed a commit to Schoolkid1/jerboa that referenced this issue Aug 13, 2023
Schoolkid1 pushed a commit to Schoolkid1/jerboa that referenced this issue Aug 13, 2023
Schoolkid1 pushed a commit to Schoolkid1/jerboa that referenced this issue Aug 15, 2023
Processed feedback into code
@dessalines dessalines changed the title Unblock a community Add Community and Instance blocks to user settings Feb 14, 2024
@dessalines dessalines changed the title Add Community and Instance blocks to user settings Add Community, Instance, and User blocks to user settings Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - medium priority This issue needs to be considered, but may not be a priority for the next release enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants