Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure storage / password protect #572

Closed
3 tasks done
grrrrr opened this issue Jun 12, 2023 · 5 comments
Closed
3 tasks done

Secure storage / password protect #572

grrrrr opened this issue Jun 12, 2023 · 5 comments
Labels
1 - low priority This issue is nice to have but not imminently planned. If you need it soon, consider making a PR enhancement New feature or request

Comments

@grrrrr
Copy link

grrrrr commented Jun 12, 2023

  • Did you check to see if this issue already exists?
  • Is this only a single feature request? Do not put multiple feature requests in one issue.
  • Is this a question or discussion? Don't use this, use https://lemmy.ml/c/jerboa

** Describe the feature request below **

Giving the wide range of topics discussed on Lemmy, some of which could get you in trouble in various contries, I would like to suggest a new feature that would allow the data to be stored in an encrypted database with the option to password protect the data.

This could be achieved by using @GuardianProjects SQLcipher.

@grrrrr grrrrr added the enhancement New feature or request label Jun 12, 2023
@twizmwazin twizmwazin added the 1 - low priority This issue is nice to have but not imminently planned. If you need it soon, consider making a PR label Jun 14, 2023
@MV-GH
Copy link
Collaborator

MV-GH commented Jun 15, 2023

What data are we talking about here? posts comments? Jerboa doesn't store those, atm it doesn't even cache. It only stores your appsettings hardly anything "dangerous".

@twizmwazin
Copy link
Contributor

The main thing I imagine one might be concerned about is their login credentials. However, locking a password behind another password doesn't seem like the best approach. It would probably make more sense to allow users to sign in but have their login credentials/token cleared when the app is closed instead of saved to the database.

@beatgammit
Copy link
Contributor

beatgammit commented Jun 17, 2023

atm it doesn't even cache

It will once #621 is implemented.

Perhaps we can use Android Keystore to store the encryption secrets. It would be extra cool if we could integrate with password managers if users prefer that (e.g. just mark a field as a password field and the password manager would autofill).

@grrrrr
Copy link
Author

grrrrr commented Jun 18, 2023

@MV-GH I am in a country and do work where risk of phone and computer confiscation is high. I am looking to make it harder to have people access the app and see what I do on it or who I am in the fediverse as some of the information accessed can be quite against the government thought.

@dessalines
Copy link
Member

This doesn't store any passwords, but the JWT. But if someone wants to do this I can re-open.

@dessalines dessalines closed this as not planned Won't fix, can't repro, duplicate, stale Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - low priority This issue is nice to have but not imminently planned. If you need it soon, consider making a PR enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants