Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODOs for initial release #2

Closed
64 of 68 tasks
PEMapModder opened this issue May 28, 2014 · 45 comments
Closed
64 of 68 tasks

TODOs for initial release #2

PEMapModder opened this issue May 28, 2014 · 45 comments
Assignees

Comments

@PEMapModder
Copy link
Member

  • Work with xEcon (dependency)
    • xEcon permissions
  • Commands
    • /f
      • /f claim
        • power check (needs to wait for mroe StatsCore functions)
        • xEcon money check
      • /f create
        • name validation
          • regular expression in config file
          • avoid repetitions
      • /f disband
      • /f donate
      • /f home
        • multiple homes
      • /f homes
      • /f info
      • /f invite
      • /f join
      • /f kick
      • /f money
        • deposit
        • withdraw
        • check
      • /f motto
        • take money
      • /f perm
        • assigning members to ranks
        • adding new ranks
        • renaming ranks
        • default/truce/ally/standard ranks
        • removing ranks and safely reassigning members to other ranks
      • /f quit
      • /f rel
      • /f rename
        • take money
      • /f sethome
        • multiple homes (wrote this again to spam TODOs to look nicer xD)
      • /f setopen
        • take money
      • /f siege
      • /f unclaim
      • /f unclaimall
    • /fadm
      • /fadm on
      • /fadm off (spamming checks to make it look nicer :P)
  • Work with the permissions internally and permissions externally (relations; with ref to MassiveCraft/Factions)
    • Internal ranks
    • External relations
      • Allies
      • Truce
      • Neutral
      • Enemy
    • Building permissions
    • PvP permissions
  • Add redirector from commands to functions
  • Power (dependency StatsCore will do it)
  • faster searching (refer to Faster search and data processing #7)
  • "Sieging" chunks (claiming a chunk that was claimed by a faction with overdraft chunks:power)
    • Arguments for sieging chunks
      • Owner faction has power overdraft
      • Sieger faction has excess power even after sieging
      • Close enough to the chunk centre to claim it
  • Staff commands
  • Debug!
  • External API
    • Event system
    • Convenient getters
@PEMapModder PEMapModder added this to the Initial release milestone May 28, 2014
@iJoshuaHD
Copy link

5 checklist that looks so simple to be finished xD

@lgibson02
Copy link

I personally hate using GitHub.

@iJoshuaHD
Copy link

BitBucket.org wont allow me to use my GitHub account which sucks :(

@PEMapModder
Copy link
Member Author

This sounds so simple. After an hour reading all the PC documentation I think I should add more details here.

@PEMapModder
Copy link
Member Author

Eight checks now. How do you feel? Still looking so simple? XD

@iJoshuaHD
Copy link

it looks still simple but the work is getting harder xD

@PEMapModder
Copy link
Member Author

10 now after the disccusion just now. (I talked with you for two hours! I didn't know that, @iJoshuaHD!)

@iJoshuaHD
Copy link

now my nose starts to irretate xD almost bleeding :D

@PEMapModder
Copy link
Member Author

lol

@iJoshuaHD
Copy link

i guess we should remove/cancel the seiging feature.

@PEMapModder
Copy link
Member Author

Why?

The owner can disable the feature if he wants.

@iJoshuaHD
Copy link

oh well... it sucks because its annoying to see factions claimed beside your faction.

@PEMapModder
Copy link
Member Author

Cleaned some duplicated checks with nests.
How does it look now?

@PEMapModder
Copy link
Member Author

22/51 tasks complete now!

@PEMapModder PEMapModder modified the milestone: Initial release Jul 9, 2014
@iJoshuaHD
Copy link

have you think that if you donate xEcon Money to the faction money, they can claim more chunks? what i mean is, Can you remove the feature where faction members/owner could NOT add money to their Faction, instead, the faction will only earn money on certain reasons. example is when they kill another faction team players.

the reason why is, they could just make another player account, add them to the faction, that player account has a default of 1000$(for example) xEcon Money, that money will be donated to the faction and they'll do that process all over and over again.

@PEMapModder
Copy link
Member Author

They need both money and power to claim chunks.

First of all, about xEcon, players can always pay themselves money by new accounts using /pay. Discuss about that in LegendOfMCPE/xEcon#1.
Secondly, they need power to claim chunks. All players start with 0 power. XEcon money only makes them to need to have one more thing to give when they claim chunks. But their total number of chunks is still controlled by their power such that if they don't have enough total online time, they can't claim chunks.
If they have time to make new accounts, they get higher total online time by staying at the same account.

As for the xEcon thing, they can be prevented by instead of giving each account default money, give each IP default money only once. And don't talk to me about VPN before you find me a Bukkit plugin that disallows using VPN networks to bypass IP ban.

@PEMapModder
Copy link
Member Author

I'll stick to @MassiveCraft's plugin in the inter faction relations.

@PEMapModder
Copy link
Member Author

Also, players can't withdraw money from the faction account.

@iJoshuaHD
Copy link

i mean deposit xEcon money. Dont allow players to deposit money to their factions. And, we should limit the number of claims to avoid large part of the world claimed by one faction if their powers is plenty.

@PEMapModder
Copy link
Member Author

Why not? Power is also calculated via kills and deaths. Anyway, the maximum claims can be limited, of course, easily. Just add that. However, I personally don't advise that.

@PEMapModder
Copy link
Member Author

Added three more TODOs at the bottom.

@PEMapModder PEMapModder self-assigned this Jul 16, 2014
@PEMapModder
Copy link
Member Author

55/66 checks now!

@lgibson02
Copy link

I think /f perm should be /f rank. I just think it goes better since it's for editing ranks.

@PEMapModder
Copy link
Member Author

@Dinokill your choice :) as you like

And you don't need to modify the class name if you don't like to

@PEMapModder
Copy link
Member Author

An idea:

/f rank appoint|app|promote|demote <player> <rank>
/f rank add|new <new rank name> <permission>,[permission],[permission]...
/f rank modify|mod <rank> <permission>,[permission]...
/f rank remove|rm <rank name> [rank to reassign to = default rank] (rank to assign to is what rank should players with this rank be reassigned to)
/f rank rename <old rank name> <new rank name> (the rank ID remains unchanged, so maybe add function $rank->setName())
/f rank set <rank> <default|truce|ally|standard>

It is just an idea I have a few minutes ago. You might think of, like and use a better method :)

Also, standard doesn't sound representable. Maybe you are English and think of better words xD

@iJoshuaHD
Copy link

those new features would clearly extend the release date thrice xD

@PEMapModder
Copy link
Member Author

It is not a new feature. It is a planned feature :D

@iJoshuaHD
Copy link

planned feature would still be new feature once its done :P same lol xD

@PEMapModder PEMapModder changed the title TODOs TODOs for initial release Jul 24, 2014
@iJoshuaHD
Copy link

/f perm checklist?

@PEMapModder
Copy link
Member Author

Checked!

@PEMapModder
Copy link
Member Author

@iJoshuaHD Admin commands? No idea what to do. IRC?

@iJoshuaHD
Copy link

ok

@iJoshuaHD
Copy link

omg, 4 checklist to go :O

@PEMapModder
Copy link
Member Author

@iJoshuaHD you forgot xEcon and StatsCore 😒

@DovahDoVolom
Copy link

Will this work with Economies? Plugin by OneBone

@iJoshuaHD
Copy link

@DovahDoVolom i guess it only supports xEcon for now.

@PEMapModder
Copy link
Member Author

xEcon is the only economy provider that is possible in our case, because the faction money is saved by the economy plugin, not by PocketFactions, and xEcon is the so far only plugin that allow non-player account owners.

@lgibson02
Copy link

Can't we add a feature where if xEcon is not present it saves the faction's balance in it's own file. No offense, but I don't think everyone will want to use xEcon.

@PEMapModder
Copy link
Member Author

Would be a bit complicated at the current stage.

@PEMapModder
Copy link
Member Author

I understand. Therefore, during release I'll try all possible measures to let people port economys database to xEcon.

@iJoshuaHD
Copy link

Events?

@PEMapModder
Copy link
Member Author

@iJoshuaHD an external events API

@PEMapModder
Copy link
Member Author

I'll open another issue for the rewrite in PocketFactions Beta.

@iJoshuaHD
Copy link

how about xEcon integration?

@PEMapModder
Copy link
Member Author

It should support any economy plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants