-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Registry sync v2 - API #167
Open
thecatcore
wants to merge
36
commits into
Legacy-Fabric:feature/registry-sync-v2/main
Choose a base branch
from
thecatcore:feature/registry-sync-v2/api
base: feature/registry-sync-v2/main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Registry sync v2 - API #167
thecatcore
wants to merge
36
commits into
Legacy-Fabric:feature/registry-sync-v2/main
from
thecatcore:feature/registry-sync-v2/api
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 8, 2024
thecatcore
added
enhancement
New feature or request
help wanted
Extra attention is needed
new module
New module
bikeshed
yes
draft
labels
May 9, 2024
- differentiate "synced" Index-Key-Value registries from simple Key-Value registries - start preparing registry remapping
… missing when it should.
… missing when it should. (again)
…ween their numerical ids.
thecatcore
force-pushed
the
feature/registry-sync-v2/api
branch
from
August 29, 2024 20:22
d9996b3
to
3a74c69
Compare
BoogieMonster1O1
requested changes
Oct 5, 2024
...2.2/src/main/java/net/legacyfabric/fabric/mixin/networking/versioned/PacketByteBufMixin.java
Outdated
Show resolved
Hide resolved
legacy-fabric-api-base/common/src/main/java/net/legacyfabric/fabric/api/util/Identifier.java
Show resolved
Hide resolved
....10/src/main/java/net/legacyfabric/fabric/mixin/networking/versioned/PacketByteBufMixin.java
Outdated
Show resolved
Hide resolved
...8.9/src/main/java/net/legacyfabric/fabric/mixin/networking/versioned/PacketByteBufMixin.java
Outdated
Show resolved
Hide resolved
...istry-sync-api-v1/common/src/main/java/net/legacyfabric/fabric/api/registry/v1/BiomeIds.java
Outdated
Show resolved
Hide resolved
...-api-v1/common/src/main/java/net/legacyfabric/fabric/api/registry/v1/BlockEntityTypeIds.java
Outdated
Show resolved
Hide resolved
...2/common/src/main/java/net/legacyfabric/fabric/api/registry/v2/registry/holder/Registry.java
Outdated
Show resolved
Hide resolved
…nc-v2/api # Conflicts: # legacy-fabric-registry-sync-api-v1/1.7.10/src/main/resources/registrysync.accesswidener # legacy-fabric-registry-sync-api-v1/1.8/src/main/resources/registrysync.accesswidener # legacyfabric-api/1.10.2/src/testmod/java/net/legacyfabric/fabric/test/registry/RegistryTest.java # legacyfabric-api/1.11.2/src/testmod/java/net/legacyfabric/fabric/test/registry/RegistryTest.java # legacyfabric-api/1.12.2/src/testmod/java/net/legacyfabric/fabric/test/registry/RegistryTest.java # legacyfabric-api/1.7.10/src/testmod/java/net/legacyfabric/fabric/test/registry/RegistryTest.java # legacyfabric-api/1.8.9/src/testmod/java/net/legacyfabric/fabric/test/registry/RegistryTest.java # legacyfabric-api/1.8/src/testmod/java/net/legacyfabric/fabric/test/registry/RegistryTest.java
thecatcore
added
MC1.8.9
Related to Minecraft 1.8.9
MC1.8
Related to Minecraft 1.8
MC1.7.10
Related to Minecraft 1.7.10
MC1.9.4
Related to Minecraft 1.9.4
MC1.10.2
Related to Minecraft 1.10.2
MC1.11.2
Related to Minecraft 1.11.2
MC1.12.2
Related to Minecraft 1.12.2
labels
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bikeshed
yes
enhancement
New feature or request
help wanted
Extra attention is needed
MC1.7.10
Related to Minecraft 1.7.10
MC1.8
Related to Minecraft 1.8
MC1.8.9
Related to Minecraft 1.8.9
MC1.9.4
Related to Minecraft 1.9.4
MC1.10.2
Related to Minecraft 1.10.2
MC1.11.2
Related to Minecraft 1.11.2
MC1.12.2
Related to Minecraft 1.12.2
new module
New module
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New registry api, more extensible, only handles registry infrastructure (remapping included).
Individual registries for content are moved to their own module in other pr depending on this one.