-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XSS vulnerability with the Quill field #129
Comments
Since I focused on implementation, this project is actually vulnerable to XSS attacks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
it seems no operation is done, on form submission or on access to quill.html, to ensure that the HTML tags of the quill field are secure and correspond to the allowed tags of the JS widget.
So anybody with access to a form can inject harmful content (<script> tags, javascript: urls) into the database data, which would then be executed client-side if he user has "marked safe" the quill content.
Sanitizing (e.g. with Bleach) would be required on input or output to prevent this.
If sanitizing is out-of-scope of this module, maybe a big Warning in the docs and readme would be useful instead ?
The text was updated successfully, but these errors were encountered: