Implement cx_bn_gf2_n_mul #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You seem to have expertise in this area so if I may ask a question. This pull request is a straightforward implementation of Galois field multiplication for Nano S devices. It is probably not very efficient but seems to work nonetheless. I notice that all devices except Nano S use a syscall to perform this function. That syscall makes use of the second Montgomery constant. I assume the use of the Second Montgomery constant in Note I may move this PR to the ledger-secure-sdk repo as that seems to be replacing nanos-secure-sdk |
aido
force-pushed
the
cx_bn_gf2_n_mul
branch
2 times, most recently
from
659250f
to
852582d
Compare
Workaround that implements cx_bn_gf2_n_mul() in the SDK until it is hopefully added as a syscall like all other Ledger devices Fixes LedgerHQ#64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64
This PR is a workaround that implements
cx_bn_gf2_n_mul()in the SDK until it is hopefully added as a syscall like in all other Ledger devices.As the second Montgomery constant (
bn_h) is an unused attribute here it begs the question how is the second Montgomery constant (bn_h) used in the implementation ofcx_bn_gf2_n_mul()on Nano S Plus, Nano X and Stax devices? Is it also unused on these devices?Note
The code in this PR is already included in the app-seed-tool which has passed Ledger's security review.