[Bug]: Incompatible with @ledgerhq/errors

[josephchung796]

Impacted Library name

@ledgerhq/hw-transport, @ledgerhq/errors

Impacted Library version

6.30.5, 6.16.4

Describe the bug

Error type - TransportRaceCondition used in @ledgerhq/[email protected] doesn't exist in @ledgerhq/[email protected].

Expected behavior

If I use @ledgerhq/[email protected], it works fine with @ledgerhq/[email protected].

Additional context

No response

[coredomain]

Any ETA for this issue.

[josephchung796]

It would be great to fix this issue until this weekend.

[coredomain]

You could temporarily solve it by adding this in line 91 export const TransportRaceCondition = createCustomErrorClass("TransportRaceCondition"); in the index.js found at node_modules/ledgerhq/errors/lib-es/index.js Builds out of your dev environments will not work because the packages will be restored from public repos. Another solution you can try is to create your local repository and point your restore endpoint to it. Just make sure you apply this change in your local repo, and later, when the issue is fixed, update your local repos with the public. I know you did not ask but for other people out there.

…

On Tue, May 21, 2024 at 2:07 PM josephchung796 ***@***.***> wrote: It would be great to fix this issue until this weekend. — Reply to this email directly, view it on GitHub <#6882 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACC4WARLBXWRZ7HTORFKAFDZDOEOTAVCNFSM6AAAAABH6QYT4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRTGE3DONBQHE> . You are receiving this because you commented.Message ID: ***@***.***>

[josephchung796]

Ok, thanks for your help, @coredomain

[josephchung796]

Once this issue is permanently fixed in public repo, please let me know.
So that I can update my project and close this issue.

[gre]

@aussedatlo fyi it may relates to your changes in #6394 , i just don't understand how it's possible that hw-transport is published but not errors , libs are supposed to be published together, unless we forgot to declare the changes using changeset for errors lib?

[aussedatlo]

The changeset for #6394 does not specify modifications to the 'errors' package, so it was not published as intended.

[aussedatlo]

Like @devfive suggest here: #6394 (comment)

We should bring back TransportRaceCondition with depreciation notice to avoid breaking changes.

[Davincible]

anza-xyz/wallet-adapter#949

Becoming a big issue for the community as building anything with @solana/wallet-adapter-wallets is now broken. Would be massive headache saver to get this resolved

[Tilakraj0308]

Any updates on this?? Please if anyone knows

[josephchung796]

Thanks very much.

[PdroCorrea]

This still isn't on npm, after reading this thread I installed 16.4 and it didn't work after installing 16.3 finally got it work! Just as fyi until new package is out, for anyone still having this issue.

[coredomain]

Thanks for the updateSent from my iPhoneOn Jun 3, 2024, at 6:35 PM, PdroCorrea ***@***.***> wrote: This still isn't on npm, after reading this thread I installed 16.4 and it didn't work after installing 16.3 finally got it work! Just as fyi until new package is out, for anyone still having this issue. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

[josephchung796]

This issue still exists on npm package.

[roguzh]

It looks like hw-transport's dependency is still not updated and keep causing this error.

[svein1010]

@ledgerhq/errors has BREAKING CHANGEs but it just update with the minor version. Could you please make @ledgerhq/transport works fine with minor version change such as @ledgerhq/errors@^6.10.0 ?