Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exchanged value estimation in market mode #3

Closed
jondubois opened this issue Apr 7, 2020 · 3 comments
Closed

Fix exchanged value estimation in market mode #3

jondubois opened this issue Apr 7, 2020 · 3 comments
Assignees
@sacOO7

Comments

@jondubois
Copy link
Member

See Jaxkr#1
@sacOO7 sacOO7 self-assigned this Apr 25, 2020
sacOO7 added a commit that referenced this issue Apr 29, 2020
@sacOO7
[created test-data orderbook raw fixtures for calculating estimated v…
b1a6b65 
…alue

of returns corresponding to given asks or bids][references issue #3]
@sacOO7
Copy link
Collaborator

sacOO7 commented Apr 29, 2020

Need to make sure orderbook is updated right before estimation is generated.

sacOO7 added a commit that referenced this issue Apr 29, 2020
@sacOO7
[Created first orderbook based on realtime queue data][references issue
521c506 
#3]
sacOO7 added a commit that referenced this issue May 1, 2020
@sacOO7
[added test for estimation based on orderbook][references issue #3]
e5fb0cf
sacOO7 added a commit that referenced this issue May 1, 2020
@sacOO7
[updated testes for lsh buyers and sellers][references issue #3]
9943817
sacOO7 added a commit that referenced this issue May 1, 2020
@sacOO7
[renamed test folder, making each test file to have .test postfix]
921df3e 
[references issue #3]
sacOO7 added a commit that referenced this issue May 3, 2020
@sacOO7
[modified test to represent domain driver scenarios][references issue #3
3f5a52d 
]
sacOO7 added a commit that referenced this issue May 3, 2020
@sacOO7
[updated test orderbook, changed unit used to represent price]
7266cf1 
[references issue #3]
sacOO7 added a commit that referenced this issue May 3, 2020
@sacOO7
[added utils to calculate estimated returns for buyer and seller]
c4f1267 
[updated tests and scenarios for the same]
[references issue #3]
sacOO7 added a commit that referenced this issue May 4, 2020
@sacOO7
[renamed orderbook1 to orderbook][added manual test scenarios]
9fa2939 
[references issue #3]
sacOO7 added a commit that referenced this issue May 4, 2020
@sacOO7
[Capped decimal places for estimated returns to 4 digits][references
14ba6cc 
issue #3]
sacOO7 added a commit that referenced this issue May 4, 2020
@sacOO7
[Fixed test based on partial matching][references issue #3]
858f15a
sacOO7 added a commit that referenced this issue May 4, 2020
@sacOO7
[renamed existing return functions to flat returns]
091b781 
[added more functions to calculate best returns]
[references issue #3]
sacOO7 added a commit that referenced this issue May 4, 2020
@sacOO7
[updated bestReturns utils and tests for the same][#3]
725b7bf
sacOO7 added a commit that referenced this issue May 5, 2020
@sacOO7
[refactored orderbook][updated utils, added getUIOrderBook method]
e11b833 
[Added tests for the same][#3]
sacOO7 added a commit that referenced this issue May 6, 2020
@sacOO7
[Refactored placeorder component]
0d60781 
[Added common utility function for calculating estimated returns based
on clean orderbook]
[removed redundunt tests for keys and values]
[#3]
@sacOO7
Copy link
Collaborator

sacOO7 commented May 6, 2020

Serious issue with component rendering (PlaceOrder.jsx)-> getting rendered again and again. Need to look into component profiling.

sacOO7 added a commit that referenced this issue May 9, 2020
@sacOO7
[Fixed bug, where estimation returns all available orders for NaN value]
56b02c4 
[#3]
@sacOO7 sacOO7 mentioned this issue May 9, 2020
Merged
sacOO7 added a commit that referenced this issue May 9, 2020
@sacOO7
[Updated App.jsx to load data parallely for updating orderbook and price
3b8c12b 
history UI][#3]
sacOO7 added a commit that referenced this issue May 9, 2020
@sacOO7
[moved estimated returns call under render]
dc5d310 
[added order matching status for all type of orders]
[#3]
sacOO7 added a commit that referenced this issue May 9, 2020
@sacOO7
[added local cleanAmount function to return float or 0 value from str…
f2b3203 
…ing]

[#3]
@sacOO7
Copy link
Collaborator

sacOO7 commented May 10, 2020

Fixed component rendering issue and did some quick bug fixes :)

@sacOO7 sacOO7 closed this as completed May 10, 2020
sacOO7 added a commit that referenced this issue May 14, 2020
@sacOO7
[Added more verbose estimation for returns][updated estimation utils][#3
2e2dde9 
]
@sacOO7 sacOO7 mentioned this issue May 14, 2020
Merged
sacOO7 added a commit that referenced this issue May 14, 2020
@sacOO7
[updated tests for estimated returns][#3]
a39fc77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sacOO7 sacOO7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jondubois @sacOO7