Resolve #43 -- Code rework #44
Conversation
There was a problem hiding this comment.
I didn't review your styles since you are wildly inconsistent with how you format your less files. Mixed indentation, spaces before commas and no spaces before commas, lines over 300 characters long just to mention a few things. I recommend you get a proper editor to work on this project, since you're obviously not using one (or you're not using it properly).
| messages: [], | ||
| lobby: NetworkServiceStatic.currentLobby, | ||
| network: NetworkService, | ||
| isHost: this.isHost, |
| get playerSettings() { | ||
| return this.settings.playerSettings; | ||
|
|
||
| iconByUser(user: { idServer: number}) { |
There was a problem hiding this comment.
iconForUser would be a better name, fix the spacing, get a complete type in here.
| } | ||
| } | ||
|
|
||
| data() { | ||
| this.canCreateLobby = true; |
There was a problem hiding this comment.
This should go in the data initializer.
| network: NetworkService | ||
| network: NetworkService, | ||
| staticService: StaticService, | ||
| lobbySelected: undefined, |
There was a problem hiding this comment.
This should be null, not undefined.
| }; | ||
| } | ||
|
|
||
| select(lobby: lobby.LobbyListItem) { | ||
| this.lobbySelected = lobby; |
There was a problem hiding this comment.
selectedLobby would be a better name.
src/ui/services/networkService.ts
Outdated
| }); | ||
| function startGame(gameServerPort){ | ||
| function startGame(data){ |
There was a problem hiding this comment.
Nested functions are never a good idea.
src/ui/services/networkService.ts
Outdated
| execFile.execFile(configContent.pathToLolExe, | ||
| args, {cwd: configContent.pathToLolFolder, maxBuffer: 1024 * 90000}, | ||
| execFile(localStorage.getItem("path") + "/League of Legends.exe", | ||
| args, {cwd: localStorage.getItem("path"), maxBuffer: 1024 * 90000}, |
There was a problem hiding this comment.
Either leave this on a single line or indent it properly, this is one statement that looks like two.
src/ui/services/networkService.ts
Outdated
| this.emit("host", true); | ||
| } else { | ||
| this.emit("host", false); | ||
| } |
There was a problem hiding this comment.
this.emit("host", data.isHost)
src/vendor/protocol.d.ts
Outdated
| @@ -153,7 +153,7 @@ declare namespace lobby { | |||
| /** Name of the lobby. */ | |||
| name: string; | |||
| /** Creator of the lobby. */ | |||
src/vendor/protocol.d.ts
Outdated
| id: number; | ||
|
|
||
| iconURL: string; | ||
| } |
Code rework, new design and summoner icons
Refs #43