From c52e2a5a33be0adbebdae2945f0e564774566331 Mon Sep 17 00:00:00 2001 From: Ralph Mack Date: Sat, 3 Feb 2024 15:24:33 -0500 Subject: [PATCH] Fixing typo in release script --- .github/workflows/release.yml | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index c408480..bed4cb3 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -19,8 +19,8 @@ jobs: # Tag name: ${{ steps.get_vars.outputs.TAG_NAME }} # Zip name: ${{ steps.get_vars.outputs.ZIP_NAME }} # Expected Release Download URL: ${{ steps.get_vars.outputs.RELEASE_DOWNLOAD_URL }} - # Expected Release system.json URL: ${{ steps.get_vars.outputs.RELEASE_INSTALL_URL }} - # Stringified system.json contents: ${{ steps.get_vars.outputs.SYSTEM_JSON }} + # Expected Release module.json URL: ${{ steps.get_vars.outputs.RELEASE_INSTALL_URL }} + # Stringified module.json contents: ${{ steps.get_vars.outputs.MODULE_JSON }} - name: Set up variables id: get_vars run: | @@ -28,25 +28,25 @@ jobs: echo "TAG_NAME=$TAG" >> $GITHUB_OUTPUT echo "ZIP_NAME=torch-$TAG.zip" >> $GITHUB_OUTPUT echo "RELEASE_DOWNLOAD_URL=https://github.com/${{github.repository}}/releases/download/$TAG/torch-$TAG.zip" >> $GITHUB_OUTPUT - echo "RELEASE_INSTALL_URL=https://github.com/${{github.repository}}/releases/download/$TAG/system.json" >> $GITHUB_OUTPUT - JSON=$(cat ./system.json) - echo ::set-output name=SYSTEM_JSON::${JSON//'%'/'%25'} + echo "RELEASE_INSTALL_URL=https://github.com/${{github.repository}}/releases/download/$TAG/module.json" >> $GITHUB_OUTPUT + JSON=$(cat ./module.json) + echo ::set-output name=MODULE::${JSON//'%'/'%25'} - # Run some tests to make sure our `system.json` is correct + # Run some tests to make sure our `module.json` is correct # Exit before setting up node if not - name: Verify correct naming env: TAG_NAME: ${{ steps.get_vars.outputs.TAG_NAME }} RELEASE_DOWNLOAD: ${{steps.get_vars.outputs.RELEASE_DOWNLOAD_URL}} - # Extract version and download url from system.json + # Extract version and download url from module.json # https://docs.github.com/en/actions/learn-github-actions/expressions#fromjson - PACKAGE_VERSION: ${{fromJSON(steps.get_vars.outputs.SYSTEM_JSON).version}} - PACKAGE_DOWNLOAD: ${{fromJSON(steps.get_vars.outputs.SYSTEM_JSON).download}} + PACKAGE_VERSION: ${{fromJSON(steps.get_vars.outputs.MODULE_JSON).version}} + PACKAGE_DOWNLOAD: ${{fromJSON(steps.get_vars.outputs.MODULE_JSON).download}} run: | # Validate that the tag being released matches the package version. if [[ ! $TAG_NAME == release-$PACKAGE_VERSION ]]; then - echo "The system.json version does not match tag name." - echo "system.json: $PACKAGE_VERSION" + echo "The module.json version does not match tag name." + echo "module.json: $PACKAGE_VERSION" echo "tag name: $TAG_NAME" echo "Please fix this and push the tag again." exit 1 @@ -54,8 +54,8 @@ jobs: # Validate that the package download url matches the release asset that will be created. if [[ ! $RELEASE_DOWNLOAD == $PACKAGE_DOWNLOAD ]]; then - echo "The system.json download url does not match the created release asset url." - echo "system.json: $PACKAGE_DOWNLOAD" + echo "The module.json download url does not match the created release asset url." + echo "module.json: $PACKAGE_DOWNLOAD" echo "release asset url: $RELEASE_DOWNLOAD" echo "Please fix this and push the tag again." exit 1