Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have bank items appear in same order as they do in the bank #10

Open
Lazyfaith opened this issue Nov 23, 2021 · 0 comments
Open

Have bank items appear in same order as they do in the bank #10

Lazyfaith opened this issue Nov 23, 2021 · 0 comments

Comments

@Lazyfaith
Copy link
Owner

Currently the items in the list appear partially out of order. Items in bank tabs will appear first and then items not in any bank tabs will appear at the end, whilst in game the items not in any bank tabs are the ones that appear first at the top of the bank.

Data about which items are in which bank tab can be gotten from the Client instance by calling the Client#getVar method, check the VarBits class to see what you pass in to get the bank tab item data (the returned value should then tell you how many items are in each tab).
According to Adam, if there's no bank tabs then the items are just in tab 1 (he told me that a year ago now so could be good to verify).

Out of scope:

  • Actually adding bank tabs to the save data (just want to get the order of the items correct)
  • Sorting old bank saves that're out of order (they'll get overwritten eventually, or not, no big deal. We just want new saves created from current banks to be correct)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant