Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dfhack portion of PyLNP.json empty #9

Open
XVicarious opened this issue May 2, 2015 · 6 comments
Open

dfhack portion of PyLNP.json empty #9

XVicarious opened this issue May 2, 2015 · 6 comments
Labels

Comments

@XVicarious
Copy link

This causes none of the preinstalled hacks to show up in the DFHack tab.

I'll give this a look and possibly make a pull request myself.

@lethosor lethosor added the config label May 2, 2015
@lethosor
Copy link
Member

lethosor commented May 2, 2015

@PeridexisErrant is the file your pack uses available on Github?

@XVicarious
Copy link
Author

I just looked, he does:

https://github.com/PeridexisErrant/LNP-shared-core/blob/master/LNP/PyLNP.json

Last updated January 30th. Not sure how much has changed though.

@lethosor
Copy link
Member

lethosor commented May 2, 2015

This is the file in this organization's repo, although PeridexisErrant's fork is ahead by a few commits. I'll merge that in, but I think there have been changes made in that pack more recently that aren't in either repo.

@PeridexisErrant
Copy link
Member

Yeah, updating that is on my to-do list. It's not quite a copy-paste job though, because there's some stuff specific to the windows version or dependant on some config not shared by other packs. With a new DF release soonish though it just moved up in priority to ensure rebuilding the pack from scratch is reasonably practical.

@BeauBouchard
Copy link
Member

I previously left this out, because it was difficult to test all the presets when compiling the package on multiple distros. Although its something that i enjoyed with the window's version that the linux version lacks. I am looking into adding this now for the next build as well as upgrading DFhack r3, and the other neglected updates for linux package.

@lethosor
Copy link
Member

It should be cross-platform, so I don't think differences between distros should affect it either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants