Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Low contrast selection field with disabled attribute #177

Open
tringuyenduc2903 opened this issue Apr 18, 2024 · 1 comment
Open
Assignees
Labels
bug Something isn't working Priority: SHOULD

Comments

@tringuyenduc2903
Copy link

tringuyenduc2903 commented Apr 18, 2024

Bug report

What I did

Create a select field

        // type: relationship (BelongsTo)
        CRUD::field('user')
            ->label(ucfirst(trans('validation.attributes.customer')))
            ->attributes(['disabled' => 'disabled']);

What I expected to happen

In Dark theme, with disabled attribute, users can monitor old data

What happened

In Dark theme -> Bad
image

In Light theme -> Good
image

What I've already tried to fix it

Edit css

Is it a bug in the latest version of Backpack?

After I run backpack composer update backpack/crud the error it still persists

Backpack, Laravel, PHP, DB version

When I run php artisan backpack:version the output is:

### PHP VERSION:
8.3.4

### PHP EXTENSIONS:
Core, date, libxml, openssl, pcre, zlib, filter, hash, json, pcntl, random, Reflection, SPL, session, standard, sodium, mysqlnd, PDO, xml, bcmath, calendar, ctype, curl, dom, mbstring, FFI, fileinfo, ftp, gd, gettext, iconv, igbinary, imagick, imap, intl, ldap, exif, msgpack, mysqli, pcov, pdo_mysql, pdo_pgsql, pdo_sqlite, pgsql, Phar, posix, readline, redis, shmop, SimpleXML, soap, sockets, sqlite3, sysvmsg, sysvsem, sysvshm, tokenizer, xmlreader, xmlwriter, xsl, zip, memcached, swoole, Zend OPcache, xdebug

### LARAVEL VERSION:
11.4.0.0

### BACKPACK PACKAGE VERSIONS:
backpack/activity-log: 2.0.4
backpack/backupmanager: v5.0.2
backpack/basset: 1.3.3
backpack/crud: 6.7.9
backpack/filemanager: 3.0.7
backpack/generators: v4.0.5
backpack/language-switcher: 2.0.0
backpack/logmanager: v5.0.1
backpack/medialibrary-uploaders: 1.2.0
backpack/permissionmanager: 7.2.0
backpack/pro: 2.1.13
backpack/revise-operation: 2.0.0
backpack/theme-tabler: 1.2.8
backpack/translation-manager: 1.0.2
@karandatwani92
Copy link
Contributor

karandatwani92 commented Apr 18, 2024

Hey @tringuyenduc2903

When I disabled the select field, it was different than yours in the dark theme. But yes, there is an issue...

@pxpm In my test, enabled and disabled fields have no visual difference in the dark theme.
chrome-capture-2024-4-18

@karandatwani92 karandatwani92 added Priority: SHOULD bug Something isn't working labels Apr 18, 2024
@karandatwani92 karandatwani92 transferred this issue from Laravel-Backpack/community-forum Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority: SHOULD
Projects
Status: No status
Development

No branches or pull requests

3 participants