Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Use bootstrap-milestones for the interface #6

Open
tabacitu opened this issue Aug 30, 2020 · 4 comments
Open

[Proposal] Use bootstrap-milestones for the interface #6

tabacitu opened this issue Aug 30, 2020 · 4 comments
Assignees

Comments

@tabacitu
Copy link
Member

Feature Request

What's the feature you think this package should have?

Cleaner timeline view, by using https://jablon.me/bootstrap-milestones/

Have you already implemented a prototype solution, for your own project?

No... 👀

Do you see this as a core feature or an add-on?

Part of the Revise operation, definitely. But it'll probably be a breaking change since it needs one additional CSS file.

@tabacitu tabacitu self-assigned this Aug 30, 2020
@mamarmite
Copy link

Not that productive comment, but maybe it's in the right direction ?
I'm using the package in my current project.

I saw this feature Request and put a small amount of work (only in the project for now).
I manage to use only basic bootstraps, 1 line in style="" :$ to put negative margin.

Screenshot_2021-02-18 Activité Historique TRGIRTO Calendrier des chantiers

@tabacitu
Copy link
Member Author

I love that @mamarmite - I would much rather do it using Bootstrap alone than tying ourselves to a new dependency. If you can submit a PR I will gladly take a look and merge - seems like a non-breaking change.

@tabacitu
Copy link
Member Author

@mamarmite any chance you can copy-paste your view code here? We'll soon be giving this repo some much-needed love, and if we have you interface code we might just add it for everyone.

Thanks!

@mamarmite
Copy link

mamarmite commented Mar 15, 2022

Hi @tabacitu Yess no problem. I push the current state here :
https://github.com/mamarmite/backpack-revise-operations-views-refactored-as-timeline/tree/master

I must say that it contains a checkup to avoid adding a revision for the create_at revisions. It's part of the reason why I didn't share this sooner, that must be set cleaner as a config.

I refactored the structure too, like to Dry a bit for me, but this add view rendering. I didn't check the loading speed impact tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants