Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5][Feature][Ready] Export improvements #1703

Merged
merged 4 commits into from
Nov 15, 2018
Merged

Conversation

tabacitu
Copy link
Member

@tabacitu tabacitu commented Nov 15, 2018

Done:

  • added visibleInExport option to columns (default: true);
  • bulk checkbox column is visibleInExport=false;
  • actions column is visibleInExport=false;
  • added visibleInTable option to columns (default: true); this is instead of the proposed and natural hidden option (proposed here [Question] Setting column visibility by default #1529), because we already have visibleInModal and the declarations should at least be consistent within columns, before they're consistent between columns and fields;

Todo:

  • add visibleInTable to columns docs
  • add visibleInModal to columns docs
  • add visibleInExport to columns docs
  • add orderable to columns docs

@tabacitu tabacitu changed the title [3.5][Feature] Export improvements [3.5][Feature][Ready] Export improvements Nov 15, 2018
@tabacitu
Copy link
Member Author

Merged into release PR. Can't wait to launch it :-)

@sharat-rhinofish
Copy link

sharat-rhinofish commented Nov 10, 2024

The following column definition in the setupListOperation still shows the Internal Notes JSON column. How do I hide it completely from the List view, but have it searchable as shown in the searchLogic below?

        $this->crud->addColumn([
            'name' => 'internal_notes_json',
            'label' => 'Internal Notes',
            'type' => 'hidden',
            'visibleInTable'  => false, // no need to show this.
            'visibleInModal'  => false, // would make the modal too big
            'visibleInExport' => false, // not important enough
            'visibleInShow'   => true, // boolean or closure - function($entry) { return $entry->isAdmin(); }
            'searchLogic' => function ($query, $column, $search_term) {
                // Make Search Term in Upper case as we want to use this to search tracking numbers primarily
                // and we will force the tracking number to be uppercase while populating this field.
                $query->orWhere('internal_notes_json', 'like', '%' . strtoupper($search_term) . '%');
            }
        ]);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants