Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing --server argument results in unhelpful feedback #21

Open
RubenatorX opened this issue May 1, 2024 · 3 comments
Open

Missing --server argument results in unhelpful feedback #21

RubenatorX opened this issue May 1, 2024 · 3 comments

Comments

@RubenatorX
Copy link

Since --server is an optional argument, when users fail to provide it, it results in:

mbedtls_net_connect failed.
Closing...

I haven't dug into the code enough to check but, if this defaults to localhost, it would be helpful for troubleshooting for it to at the very least say so.
If it does not default to localhost and instead just does a bad connection request, then it should probably be a required parameter, and should probably gripe specifically about it being missing.

That being said, it would also be nice if main could do a more graceful Closing... and sleep instead of instantly exiting at the linked code.

@zach2good
Copy link
Collaborator

It does default to localhost, and this is the expected behaviour, so you can just launch xiloader without any arguments and connect to your locally running xi_connect (ignore my temporary debug logging):

image

Not against adding some more logging when a server is chosen.

xiloader is used as part of Windower and Ashita workflows, I'm not sure if it's in a fire-and-forget fashion or not, and whether or not introducing a sleep so people can see error logging is a safe move or not

@RubenatorX
Copy link
Author

Well, Windower is totally fine with it. And the terminal stays open for several seconds in the current setup anyway.
It's mostly just nice so that users can actually see the messages so that they can provide those when we're trying to help them troubleshoot.
I didn't even notice the error message I was getting for "Duplicate argument" till I added a sleep anyway (although I did later notice it when I ran it through cmd such that the output remained).

@TeoTwawki
Copy link
Contributor

Honestly, I'd really like to require the user to press a key - any key- for the program to exit. I run into way to many ppl who didn't read any instructions and just double clicked it and then tell me they "installed" it.

There is an insane level of user error around xiloader, always has been.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants