You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since --server is an optional argument, when users fail to provide it, it results in:
mbedtls_net_connect failed.
Closing...
I haven't dug into the code enough to check but, if this defaults to localhost, it would be helpful for troubleshooting for it to at the very least say so.
If it does not default to localhost and instead just does a bad connection request, then it should probably be a required parameter, and should probably gripe specifically about it being missing.
That being said, it would also be nice if main could do a more graceful Closing... and sleep instead of instantly exiting at the linked code.
The text was updated successfully, but these errors were encountered:
It does default to localhost, and this is the expected behaviour, so you can just launch xiloader without any arguments and connect to your locally running xi_connect (ignore my temporary debug logging):
Not against adding some more logging when a server is chosen.
xiloader is used as part of Windower and Ashita workflows, I'm not sure if it's in a fire-and-forget fashion or not, and whether or not introducing a sleep so people can see error logging is a safe move or not
Well, Windower is totally fine with it. And the terminal stays open for several seconds in the current setup anyway.
It's mostly just nice so that users can actually see the messages so that they can provide those when we're trying to help them troubleshoot.
I didn't even notice the error message I was getting for "Duplicate argument" till I added a sleep anyway (although I did later notice it when I ran it through cmd such that the output remained).
Honestly, I'd really like to require the user to press a key - any key- for the program to exit. I run into way to many ppl who didn't read any instructions and just double clicked it and then tell me they "installed" it.
There is an insane level of user error around xiloader, always has been.
Since
--server
is an optional argument, when users fail to provide it, it results in:I haven't dug into the code enough to check but, if this defaults to localhost, it would be helpful for troubleshooting for it to at the very least say so.
If it does not default to localhost and instead just does a bad connection request, then it should probably be a required parameter, and should probably gripe specifically about it being missing.
That being said, it would also be nice if main could do a more graceful
Closing...
and sleep instead of instantly exiting at the linked code.The text was updated successfully, but these errors were encountered: