Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item duplication; 'Trinkets' incompatibility #636

Open
Happenstance-14 opened this issue Aug 19, 2023 · 6 comments
Open

Item duplication; 'Trinkets' incompatibility #636

Happenstance-14 opened this issue Aug 19, 2023 · 6 comments
Labels
bug Something isn't working mod interaction t:confirmed Confirmed issues by triage team

Comments

@Happenstance-14
Copy link

MC 1.19.2; Requiem 2.0.0-beta.16; Trinkets 3.4.2

  • When shift-equipping a Trinket, the item will (more likely than not) equip to multiple Trinket slots, the extra of which are supposed to be invalid (i.e. a 'Shoes' Trinket should not be equipable to 'Face', yet it does); these can be removed, and the process repeated to generate infinite copies of the item.
  • When moving a Trinket by cursor to hotbar slot 1, the item is copied to the 'Face' Trinket slot.
  • With 'Artifacts' installed, moving a Trinket to hotbar slot 2 copies the item to the extra off-hand 'Glove' slot.
  • Doing all of these things in random order with various Trinkets causes increasingly complex and inexplicable duplications.

Mods:

  • Cardinal Components 5.0.2 (Trinkets dependency)
  • Cloth Config API 8.2.88-fabric (Things dependency)
  • owo-lib 0.9.3 (Things dependency)
  • Patchouli 1.19.2-77-FABRIC (Things dependency)
  • QFAPI 4.0.0-beta.30 & QSL 3.0.0-beta.29
  • Requiem 2.0.0-beta.16
  • Things 0.3.0 (Trinkets dependent for dupe testing)
  • Trinkets 3.4.2
@Redfan2 Redfan2 added bug Something isn't working mod interaction t:confirmed Confirmed issues by triage team labels Aug 20, 2023
@Happenstance-14
Copy link
Author

Known workaround is to use Patbox's Polymer port of Trinkets. Although this fork naturally comes with some spare jank when interacting with other mods, the issue I've described here does not occur. May want to cross-examine and see what each does differently, if that's useful.

@cph101
Copy link

cph101 commented Mar 19, 2024

It’s a 100% serverside port, which makes it incredibly hard to get any useful information out of. I’ve also experienced this issue while testing various modpacks without requiem, and the same appears to happen, so it’s a common issue really.

@Redfan2
Copy link
Member

Redfan2 commented Sep 14, 2024

@Pyrofab Do you have any suspicions what could be causing this?

@Pyrofab
Copy link
Member

Pyrofab commented Sep 14, 2024

Possibly Locki ? I believe it's the only library in Requiem which significantly touches the inventory

@ghotiPhoti
Copy link

i've had this issue before too, though it's not just trinkets: it's any item I put in my first slot in creative mode specifically. Sometimes, even taking duped items out of the slots or even shift clicking empty armor slots causes duping.

@ghotiPhoti
Copy link

update: the mod specifically causing it was Requiem. not sure why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mod interaction t:confirmed Confirmed issues by triage team
Projects
None yet
Development

No branches or pull requests

5 participants