Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update chai dependency that uses ESM modules #1791

Open
unjust opened this issue Mar 21, 2024 · 0 comments
Open

Update chai dependency that uses ESM modules #1791

unjust opened this issue Mar 21, 2024 · 0 comments
Labels
chore Tareas pertinentes al equipo de mantenimiento dependencies Pull requests that update a dependency file
Milestone
Issues Tech

Comments

@unjust
Copy link
Contributor

unjust commented Mar 21, 2024

Our chai dependency is still on version 4, there is version 5 but it entails that w update all the uses of require chai to ESM

For example:

Error [ERR_REQUIRE_ESM]: require() of ES Module /Users/ivy/Work/Laboratoria/repos/dev/curriculum/node_modules/chai/chai.js from /Users/ivy/Work/Laboratoria/repos/dev/curriculum/topics/functional/01-state/02-practice/01-discount/test/discount.spec.js not supported.
@unjust unjust added this to the v8.6.0 milestone Apr 3, 2024
@unjust unjust linked a pull request Apr 9, 2024 that will close this issue
chore(deps): Chai update #1798
Closed
@unjust unjust modified the milestones: v8.6.0 , v8.7.0 Apr 12, 2024
@unjust unjust removed this from the v8.7.0 milestone May 16, 2024
@unjust unjust added dependencies Pull requests that update a dependency file chore Tareas pertinentes al equipo de mantenimiento labels Oct 15, 2024
@unjust unjust added this to the Issues Tech milestone Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Tareas pertinentes al equipo de mantenimiento dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
Issues Tech
Development

Successfully merging a pull request may close this issue.

chore(deps): Chai update Laboratoria/curriculum
1 participant
@unjust