Refactor Plate cache #4694
Merged
Refactor Plate cache #4694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add plate custom fields to plate cache
return metadata domain ID from Plate
labkey-nicka
approved these changes
Aug 23, 2023
| * capability to resolve vocabulary columns by field key or name. | ||
| */ | ||
| @Override | ||
| protected ColumnInfo resolveColumn(String name) |
There was a problem hiding this comment.
I'm curious what you think it would take to allow us to resolve these by another alias like Properties/columnName or PlateMetadata/columnName? Is that just a whole bag of worms?
There was a problem hiding this comment.
Yeah, this should be straight forward and I'll add it to this PR as well as update the test case to verify resolving by either PropertyURI or by FieldKey (Properties/columnName)
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Previously, we were caching plates using
containeras a key. This meant that each time a plate was un-cached, all plates in the container needed to be re-cached. We wanted to move to a finer grained per-plate cache which should improve performance as we anticipate the creation of many plates. One complication that needed to be solved is thatPlatescan be referenced by:This version of the cache uses a cache key that can be generated from each of the various reference units. When a plate is added to the cache we populate the cache with the same plate instance using the other 2 cache key variants to avoid having to re-query for a plate we already know about. The same thing happens in reverse when we un-cache a plate. An internal collection is maintained to help with the un-caching of all plates for a container.
Other Changes
biologicsmodule.domainIdof the plate metadata domain andgetPlate.apiQuery.updateRows. This now works however metadata fields are only resolved using theirPropertyURIvalues.