From 075099645546269dd4dc8951fa23fccbfcb24d9e Mon Sep 17 00:00:00 2001
From: Gary Jones <jonesga@ohsu.edu>
Date: Mon, 30 Dec 2024 14:09:12 -0700
Subject: [PATCH 1/2] Update onprc_ehr-24.004-24.005.sql

Removeed withdrawn from the query where clause
---
 .../schemas/dbscripts/sqlserver/onprc_ehr-24.004-24.005.sql   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/onprc_ehr/resources/schemas/dbscripts/sqlserver/onprc_ehr-24.004-24.005.sql b/onprc_ehr/resources/schemas/dbscripts/sqlserver/onprc_ehr-24.004-24.005.sql
index aa6901fa0..8dafb5690 100644
--- a/onprc_ehr/resources/schemas/dbscripts/sqlserver/onprc_ehr-24.004-24.005.sql
+++ b/onprc_ehr/resources/schemas/dbscripts/sqlserver/onprc_ehr-24.004-24.005.sql
@@ -15,7 +15,7 @@ WITH ApprovedProtocols AS (
     FROM
         onprc_ehr.eIACUC_PRIME_VIEW_PROTOCOLS
     WHERE
-        Protocol_State IN ('approved','expired', 'terminated', 'withdrawn')
+        Protocol_State IN ('approved','expired', 'terminated')
     GROUP BY
         BaseProtocol
 ),
@@ -44,4 +44,4 @@ Update p
 Set p.enddate = getDate() , p.contacts = 'EndDated based on Protocol_State ' + e.PROTOCOL_State
 
     from ehr.protocol p inner join expiredProtocol e on p.external_id = e.BaseProtocol
-END
\ No newline at end of file
+END

From 62407a008dd984cb6f0bcb6a089cdd3adbe3a5f2 Mon Sep 17 00:00:00 2001
From: brentlogan <gbrentlogan@gmail.com>
Date: Thu, 2 Jan 2025 17:43:55 -0800
Subject: [PATCH 2/2] Rename .xml and change descriptions

---
 ...teProtocols.xml => UpdateEhrProtocols.xml} | 21 +++++++------------
 1 file changed, 8 insertions(+), 13 deletions(-)
 rename onprc_ehr/resources/etls/{eIACUCtoPrimteProtocols.xml => UpdateEhrProtocols.xml} (55%)

diff --git a/onprc_ehr/resources/etls/eIACUCtoPrimteProtocols.xml b/onprc_ehr/resources/etls/UpdateEhrProtocols.xml
similarity index 55%
rename from onprc_ehr/resources/etls/eIACUCtoPrimteProtocols.xml
rename to onprc_ehr/resources/etls/UpdateEhrProtocols.xml
index ea306a7b2..9ddf6dec9 100644
--- a/onprc_ehr/resources/etls/eIACUCtoPrimteProtocols.xml
+++ b/onprc_ehr/resources/etls/UpdateEhrProtocols.xml
@@ -2,36 +2,31 @@
 
 <etl xmlns="http://labkey.org/etl/xml">
 
-    <name>eIACUC to Prime Protocols</name>
-
-    <description>Runs stored Procedure to update eiACUC Protocols in ehr</description>
+    <name>Update Protocols in EHR</name>
 
+    <description>Runs stored procedures to update the protocol table in schema ehr.</description>
 
     <transforms>
 
         <transform id="UpdateBaseProtocol" type="StoredProcedure">
-            <description>Runs a stored procedure that generates lab values</description>
+            <description>Determines and populates BaseProtocol and RevisionNumber data for the protocol table in schema onprc_ehr.</description>
             <procedure schemaName="onprc_ehr" procedureName="BaseProtocol">
             </procedure>
         </transform>
 
         <transform id="enddateExpiredProtocolsProtocol" type="StoredProcedure">
-            <description>Runs a stored procedure that generates lab values</description>
+            <description>Adds enddate data to the protocol table in ehr.</description>
             <procedure schemaName="onprc_ehr" procedureName="ExpiredProtocolUpdate">
             </procedure>
         </transform>
 
-
-
-
     </transforms>
 
-    <!-- <schedule>
- &#45;&#45;Runs at 8:30 AM each day
-         <cron expression="0 50 04 * * "/>
-
+    <!--
+    <schedule>
+        <cron expression="0 50 04 * * "/>
      </schedule>
- -->
+     -->
 
 </etl>