Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch recipes to use fauxSim #21

Open
djbard opened this issue Jun 6, 2014 · 1 comment
Open

Switch recipes to use fauxSim #21

djbard opened this issue Jun 6, 2014 · 1 comment
Assignees
Labels
Milestone

Comments

@djbard
Copy link
Contributor

djbard commented Jun 6, 2014

Currently the recipes call phosim via subprocess, which is ugly. They should call fauxSim instead, which is much more elegant.

@djbard djbard added this to the Launch milestone Jun 6, 2014
@djbard djbard self-assigned this Jun 6, 2014
@jchiang87
Copy link
Contributor

Hi Debbie,

BTW, I found the reason the bdgals-fixed.dat input catalog wasn't working with faux_sim.py: I'm using the parameter names in the default_instcat file, which has the names "Unrefracted_RA_deg" and "Unrefracted_Dec_deg", whereas the entries in the bdgals-fixed.dat file are missing the "_deg" suffix. That file works with the standard phosim.py because that script just matches for the substrings when going through the lines from the input catalog.

Feel free to file any issues on faux_sim.py if you have feature requests. I'm planning to add checks on the input parameters against the default_instcat entries to be sure all expected entries are present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants