Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost.py - Remove default value for r_s + fix docstring + improve function names #645

Closed
combet opened this issue Sep 30, 2024 · 0 comments · Fixed by #646
Closed

boost.py - Remove default value for r_s + fix docstring + improve function names #645

combet opened this issue Sep 30, 2024 · 0 comments · Fixed by #646
Assignees

Comments

@combet
Copy link
Collaborator

combet commented Sep 30, 2024

  • The boost factors defined in boost.py uses a default value of r_s of 1000 kpc. While the docstring does say the unit of r_s should match that of the radius vector, it is confusing to see a default value in kpc. I suggest to remove the default value to "force" the user to provide their value of r_s.

  • Also the docstring for boost0 in either the NFW or power law parametrisation is not correct (that should "Boost normalisation" and what is currently under boost0 be under Returns)

  • Finally, probably need to rename the functions correct_sigma_with_boost*, as it will generally be applied to DeltaSigma or shear rather than Sigma. Also, the NFW boost is based one the NFW DeltaSigma analytical expression, not on the Sigma one

@github-project-automation github-project-automation bot moved this to Issue to do in Towards CLMM v2.0 Sep 30, 2024
@combet combet changed the title Remove default value for r_s in boost factor calculation + fix docstring boost.py - Remove default value for r_s + fix docstring + improve function names Oct 3, 2024
@combet combet self-assigned this Oct 3, 2024
@combet combet linked a pull request Oct 3, 2024 that will close this issue
3 tasks
@github-project-automation github-project-automation bot moved this from Issue to do to Done in Towards CLMM v2.0 Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant