Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https in trackable url #97

Open
lcd1232 opened this issue Aug 8, 2017 · 4 comments
Open

https in trackable url #97

lcd1232 opened this issue Aug 8, 2017 · 4 comments

Comments

@lcd1232
Copy link
Contributor

lcd1232 commented Aug 8, 2017

Right now if you're using https on server you still get url with http, there is no checking about protocol.
Problem is here

@gotlium
Copy link
Collaborator

gotlium commented Aug 8, 2017

I think we can add new constant to fix this problem.

@lcd1232
Copy link
Contributor Author

lcd1232 commented Aug 9, 2017

@gotlium I think better provide argument like is_secure or the whole request object to def send_db_mail(*args, **kwargs) because one django server can serve many sites and some of them can using http and others https. The best way to know is https or not using check request.is_secure()

@gotlium
Copy link
Collaborator

gotlium commented Aug 10, 2017

By default we can use is_secure=False, and when required https, developer can add is_secure=request.is_secure(). PR?

@lcd1232
Copy link
Contributor Author

lcd1232 commented Aug 10, 2017

@gotlium yeah, will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants