Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle variants unsupported by VV by translating them first #584

Open
1 of 11 tasks
ifokkema opened this issue Jan 27, 2022 · 2 comments
Open
1 of 11 tasks

Handle variants unsupported by VV by translating them first #584

ifokkema opened this issue Jan 27, 2022 · 2 comments

Comments

@ifokkema
Copy link
Member

ifokkema commented Jan 27, 2022

VV doesn't support all HGVS variants, e.g. variants with uncertain positions or methylation-related variants. The VV library could handle these by translating them to supported variants before submitting them to VV, and translating the variants back when the reply comes in. This will allow us to still map these variants from genome to transcripts and vice versa. If we keep these translations within the VV library, they can more easily be dropped if VV will include support for these.

  • Make a list of unsupported variants.
    • Complex insertions, including ins100_200 and ins[...] (source). This may be hard to translate. Insertions like insA[10] are supported.
    • Methylation-related variants, can be translated to = variants.
    • Variants with uncertain positions, can be split into multiple = variants.
    • "Or" variants, e.g., c.123^124G>C, can be split into multiple variants (currently unsupported by LOVD as well).
    • Repeats, need some more work but can be translated to = variants.
    • pter, cen, qter variants, but maybe mapping those is senseless (see also Add mapping support for variants only partially intergenic openvar/variantValidator#333).
    • More?
  • This feature is only meant for when mapping is requested. If no mapping has been requested, don't call VV but just return a fake reply.
  • A wrapper function should translate or split the variant and call the regular VV function using the translated value.
  • Once the reply comes back, translate the variant back to the original type in VV's reply.

Related:

Possibly related (would need more work, better try to handle this in VV itself):

@Peter-J-Freeman
Copy link

We have an open project to handle these variants. I recommend a coordinated effort here otherwise you guys will write code that becomes redundant very quickly. This is a priority project so I am committing all available resource to it. Can we please set up a meeting to discuss.

Here is the link to the issue
openvar/variantValidator#328

@ifokkema
Copy link
Member Author

ifokkema commented Feb 1, 2022

After discussing this in a meeting;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants