Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement VariantValidator for all genome builds in variant data entry form #562

Open
7 of 8 tasks
loeswerkman opened this issue Oct 5, 2021 · 4 comments · May be fixed by #588
Open
7 of 8 tasks

Implement VariantValidator for all genome builds in variant data entry form #562

loeswerkman opened this issue Oct 5, 2021 · 4 comments · May be fixed by #588

Comments

@loeswerkman
Copy link
Collaborator

loeswerkman commented Oct 5, 2021

  • Mark all DNA fields with their genome build (instead of only the first one)
  • Allow user to map from whichever DNA field that is in the form
    • If the organism of choice is human:
      • Make sure the HGVS check works on each field (apply ONLY regular expression on any gb that is not hg19 or hg38)
      • Automatically fill all other DNA fields
    • Fill in the source
  • In inc-js-variants.php, get rid of the usage of $_GET['chromosome'] if you can (can we use the new data elements feature for this?)
  • Fix all automated tests; these would fail now since the Mutalyzer functionality has been removed.
@ifokkema
Copy link
Member

ifokkema commented Oct 5, 2021

@PeteCausey-Freeman
This will incorporate VV in the LOVD submission process. As mentioned before, my student @loeswerkman is working on supporting more than one genome build at a time in LOVD, this is one step in that process. We tried Docker today but didn't get far. I'll try again on Thursday in the office, if that doesn't work either, I'll send you the errors, maybe you can see what's up (so no need to do anything yet).

I know I am behind on my email a lot, I hope to be able to reply to all your emails today!

@Peter-J-Freeman
Copy link

No problem. I'm very close to having a live dev API running.

Still worth trying with docker.

Perhaps we can have a chat at some point @loeswerkman and work through the docker issues

@ifokkema
Copy link
Member

ifokkema commented Oct 5, 2021

Thanks! I'll let you know this Thursday how we did, with a bit of luck I can get it to run on my work PC 😄 🤞

@Peter-J-Freeman
Copy link

Get a sensible computer ;)

@loeswerkman loeswerkman linked a pull request Mar 3, 2022 that will close this issue
@loeswerkman loeswerkman reopened this Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants